| To: | xfs@xxxxxxxxxxx |
|---|---|
| Subject: | [PATCH 07/11] xfsprogs: xfs_fsr: replace sprintf with snprintf to avoid buffer overflow |
| From: | Vivek Trivedi <t.vivek@xxxxxxxxxxx> |
| Date: | Wed, 02 Dec 2015 16:49:23 +0530 |
| Cc: | a.sahrawat@xxxxxxxxxxx, pankaj.m@xxxxxxxxxxx, Vivek Trivedi <t.vivek@xxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| Dlp-filter: | Pass |
| In-reply-to: | <1449055167-19936-1-git-send-email-t.vivek@xxxxxxxxxxx> |
| References: | <1449055167-19936-1-git-send-email-t.vivek@xxxxxxxxxxx> |
Fix possible buffer overflow by replacing sprintf with snprintf in tmp_next
and tmp_close.
Reported by coverity.
Signed-off-by: Vivek Trivedi <t.vivek@xxxxxxxxxxx>
---
fsr/xfs_fsr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fsr/xfs_fsr.c b/fsr/xfs_fsr.c
index 424fbce..bd459b6 100644
--- a/fsr/xfs_fsr.c
+++ b/fsr/xfs_fsr.c
@@ -1804,7 +1804,7 @@ tmp_next(char *mnt)
{
static char buf[SMBUFSZ];
- sprintf(buf, "%s/.fsr/ag%d/tmp%d",
+ snprintf(buf, SMBUFSZ, "%s/.fsr/ag%d/tmp%d",
( (strcmp(mnt, "/") == 0) ? "" : mnt),
tmp_agi,
getpid());
@@ -1823,7 +1823,7 @@ tmp_close(char *mnt)
/* No data is ever actually written so we can just do rmdir's */
for (i=0; i < fsgeom.agcount; i++) {
- sprintf(buf, "%s/.fsr/ag%d", mnt, i);
+ snprintf(buf, SMBUFSZ, "%s/.fsr/ag%d", mnt, i);
if (rmdir(buf) < 0) {
if (errno != ENOENT) {
fsrprintf(
--
1.7.9.5
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Ich bitte um Ihre Unterstuetzung!!, Angela Williams |
|---|---|
| Next by Date: | [PATCH 05/11] xfsprogs: xfs_mdrestore: check bad read count in perform_restore, Vivek Trivedi |
| Previous by Thread: | Re: [PATCH 08/11] xfsprogs: xfs_repair: fix possible null dereference in build_ino_tree, Dave Chinner |
| Next by Thread: | Re: [PATCH 07/11] xfsprogs: xfs_fsr: replace sprintf with snprintf to avoid buffer overflow, Eric Sandeen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |