| To: | xfs@xxxxxxxxxxx |
|---|---|
| Subject: | [PATCH 02/11] xfsprogs: fix integer overflow in xlog_find_verify_cycle |
| From: | Vivek Trivedi <t.vivek@xxxxxxxxxxx> |
| Date: | Wed, 02 Dec 2015 16:49:18 +0530 |
| Cc: | a.sahrawat@xxxxxxxxxxx, pankaj.m@xxxxxxxxxxx, Vivek Trivedi <t.vivek@xxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| Dlp-filter: | Pass |
| In-reply-to: | <1449055167-19936-1-git-send-email-t.vivek@xxxxxxxxxxx> |
| References: | <1449055167-19936-1-git-send-email-t.vivek@xxxxxxxxxxx> |
Fix unintentional integer overflow in xlog_find_verify_cycle.
Reported by coverity.
Signed-off-by: Vivek Trivedi <t.vivek@xxxxxxxxxxx>
---
libxlog/xfs_log_recover.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libxlog/xfs_log_recover.c b/libxlog/xfs_log_recover.c
index ef7cf68..73f4d36 100644
--- a/libxlog/xfs_log_recover.c
+++ b/libxlog/xfs_log_recover.c
@@ -254,7 +254,7 @@ xlog_find_verify_cycle(
* try a smaller size. We need to be able to read at least
* a log sector, or we're out of luck.
*/
- bufblks = 1 << ffs(nbblks);
+ bufblks = (xfs_daddr_t)1 << ffs(nbblks);
while (bufblks > log->l_logBBsize)
bufblks >>= 1;
while (!(bp = xlog_get_bp(log, bufblks))) {
--
1.7.9.5
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 04/11] xfsprogs: xfsdb: remove unnessary checks in process_leaf_node_dir_v2_free, Vivek Trivedi |
|---|---|
| Next by Date: | [PATCH 01/11] xfsprogs: xfs_io: fix a memory leak in imap_f, Vivek Trivedi |
| Previous by Thread: | Re: [PATCH 04/11] xfsprogs: xfsdb: remove unnessary checks in process_leaf_node_dir_v2_free, Dave Chinner |
| Next by Thread: | Re: [PATCH 02/11] xfsprogs: fix integer overflow in xlog_find_verify_cycle, Eric Sandeen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |