| To: | xfs@xxxxxxxxxxx |
|---|---|
| Subject: | [PATCH 10/11] xfsprogs: fix possible null pointer dereference in xfs_iformat_extents |
| From: | Vivek Trivedi <t.vivek@xxxxxxxxxxx> |
| Date: | Wed, 02 Dec 2015 16:49:26 +0530 |
| Cc: | a.sahrawat@xxxxxxxxxxx, pankaj.m@xxxxxxxxxxx, Vivek Trivedi <t.vivek@xxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| Dlp-filter: | Pass |
| In-reply-to: | <1449055167-19936-1-git-send-email-t.vivek@xxxxxxxxxxx> |
| References: | <1449055167-19936-1-git-send-email-t.vivek@xxxxxxxxxxx> |
Fix possible null pointer dereference in xfs_iformat_extents and
xfs_iext_get_ext if fail to locate inode record.
Reported by coverity.
Signed-off-by: Vivek Trivedi <t.vivek@xxxxxxxxxxx>
---
libxfs/xfs_inode_fork.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/libxfs/xfs_inode_fork.c b/libxfs/xfs_inode_fork.c
index e1968b4..36aa0c8 100644
--- a/libxfs/xfs_inode_fork.c
+++ b/libxfs/xfs_inode_fork.c
@@ -331,6 +331,8 @@ xfs_iformat_extents(
xfs_validate_extents(ifp, nex, XFS_EXTFMT_INODE(ip));
for (i = 0; i < nex; i++, dp++) {
xfs_bmbt_rec_host_t *ep = xfs_iext_get_ext(ifp, i);
+ if (!ep)
+ return -EFSCORRUPTED;
ep->l0 = get_unaligned_be64(&dp->l0);
ep->l1 = get_unaligned_be64(&dp->l1);
}
@@ -890,6 +892,8 @@ xfs_iext_get_ext(
xfs_extnum_t page_idx = idx; /* ext index in target list */
erp = xfs_iext_idx_to_irec(ifp, &page_idx, &erp_idx, 0);
+ if (!erp)
+ return NULL;
return &erp->er_extbuf[page_idx];
} else if (ifp->if_bytes) {
return &ifp->if_u1.if_extents[idx];
--
1.7.9.5
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 06/11] xfsprogs: xfs_db: check null derefernce after block_to_bt, Vivek Trivedi |
|---|---|
| Next by Date: | [PATCH 11/11] xfsprogs: xfs_repair: fix possible null pointer dereference in mark_standalone_inodes, Vivek Trivedi |
| Previous by Thread: | Re: [PATCH 06/11] xfsprogs: xfs_db: check null derefernce after block_to_bt, Eric Sandeen |
| Next by Thread: | Re: [PATCH 10/11] xfsprogs: fix possible null pointer dereference in xfs_iformat_extents, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |