xfs
[Top] [All Lists]

[PATCH v13 43/51] ext4: Don't allow unmapped identifiers in richacls

To: Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, "Theodore Ts'o" <tytso@xxxxxxx>, Andreas Dilger <adilger.kernel@xxxxxxxxx>, "J. Bruce Fields" <bfields@xxxxxxxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxxxxxxx>, Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx>, Anna Schumaker <anna.schumaker@xxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx, linux-cifs@xxxxxxxxxxxxxxx, linux-api@xxxxxxxxxxxxxxx
Subject: [PATCH v13 43/51] ext4: Don't allow unmapped identifiers in richacls
From: Andreas Gruenbacher <agruenba@xxxxxxxxxx>
Date: Tue, 3 Nov 2015 16:17:19 +0100
Cc: Andreas Gruenbacher <agruenba@xxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1446563847-14005-1-git-send-email-agruenba@xxxxxxxxxx>
References: <1446563847-14005-1-git-send-email-agruenba@xxxxxxxxxx>
Don't allow acls which contain unmapped identifiers: they are meaningful
for remote file systems only.

Signed-off-by: Andreas Gruenbacher <agruenba@xxxxxxxxxx>
---
 fs/ext4/richacl.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/fs/ext4/richacl.c b/fs/ext4/richacl.c
index 906d048..2115385 100644
--- a/fs/ext4/richacl.c
+++ b/fs/ext4/richacl.c
@@ -74,6 +74,10 @@ __ext4_set_richacl(handle_t *handle, struct inode *inode, 
struct richacl *acl)
        int retval, size;
        void *value;
 
+       /* Don't allow acls with unmapped identifiers. */
+       if (richacl_has_unmapped_identifiers(acl))
+               return -EINVAL;
+
        if (richacl_equiv_mode(acl, &mode) == 0) {
                inode->i_ctime = ext4_current_time(inode);
                inode->i_mode = mode;
-- 
2.5.0

<Prev in Thread] Current Thread [Next in Thread>