xfs
[Top] [All Lists]

[PATCH v12 43/49] sunrpc: Allow to demand-allocate pages to encode into

To: Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, "Theodore Ts'o" <tytso@xxxxxxx>, Andreas Dilger <adilger.kernel@xxxxxxxxx>, "J. Bruce Fields" <bfields@xxxxxxxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxxxxxxx>, Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx>, Anna Schumaker <anna.schumaker@xxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx, linux-cifs@xxxxxxxxxxxxxxx, linux-api@xxxxxxxxxxxxxxx
Subject: [PATCH v12 43/49] sunrpc: Allow to demand-allocate pages to encode into
From: Andreas Gruenbacher <agruenba@xxxxxxxxxx>
Date: Fri, 23 Oct 2015 20:41:56 +0200
Cc: Andreas Gruenbacher <agruenba@xxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1445625722-13791-1-git-send-email-agruenba@xxxxxxxxxx>
References: <1445625722-13791-1-git-send-email-agruenba@xxxxxxxxxx>
When encoding large, variable-length objects such as acls into xdr_bufs,
it is easier to allocate buffer pages on demand rather than precomputing
the required buffer size.

Signed-off-by: Andreas Gruenbacher <agruenba@xxxxxxxxxx>
---
 net/sunrpc/xdr.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c
index 4439ac4..63c1c36 100644
--- a/net/sunrpc/xdr.c
+++ b/net/sunrpc/xdr.c
@@ -537,6 +537,15 @@ static __be32 *xdr_get_next_encode_buffer(struct 
xdr_stream *xdr,
         */
        xdr->scratch.iov_base = xdr->p;
        xdr->scratch.iov_len = frag1bytes;
+
+       if (!*xdr->page_ptr) {
+               struct page *page = alloc_page(GFP_NOFS);
+
+               if (!page)
+                       return NULL;
+               *xdr->page_ptr = page;
+       }
+
        p = page_address(*xdr->page_ptr);
        /*
         * Note this is where the next encode will start after we've
-- 
2.5.0

<Prev in Thread] Current Thread [Next in Thread>