xfs
[Top] [All Lists]

[PATCH 0/5 v7] xfs: stats in sysfs

To: xfs@xxxxxxxxxxx
Subject: [PATCH 0/5 v7] xfs: stats in sysfs
From: "Bill O'Donnell" <billodo@xxxxxxxxxx>
Date: Tue, 22 Sep 2015 07:07:46 -0500
Delivered-to: xfs@xxxxxxxxxxx
Hello-

Following is the next iteration of the series to add xfs stats to
sysfs. This iteration adds patch 5/5 to incorporate sysfs/kobject
into xfsstats.

----------history---------------
v7:
-add patch 5/5: incorporate sysfs/kobject in xfsstats: handlers
take kobjects. Allocate & deallocate per-fs stats structures
and set up the sysfs entries for them. Add kobject and a pointer
to a per-cpu struct xfsstats. Modify the macros that manipulate
the stats accordingly.

v6:
-add patch 4/4: move to_xlog(kobject) to the relevant show/store
operations. This keeps the xfs_sysfs_object_show/store functions
generic. Also, with the change, there can be some cleanup of the
show/store function arguments.

v5:
-optimization of sysfs_ops function.
-style fixups

v4:
-whitespace fixup of patch 1
-add patch 4 (sysfs ops consolidation - dbg, stats, log)

v3:
-style fixups and removal of extraneous printk.

v2:
-style fixups.

v1:
--------------------------------

The series provides infrastructure for per-fs stats (in addition
to global accumulative stats).

We already have per-fs information in /sys, so it makes sense to
have per-fs stats there too.  As a first step, moving existing
global stats infrastructure to /sys will allow us to re-use that
sysfs code for per-fs stats as well.

Patch 1 handles the bring-up and tear down of xfs/stats directory
structure in sysfs when an fs is mounted. The directory contains
the stats file and the stats_clear file. The stats file contents mimic
those of /proc/fs/xfs/stat. The stats_clear file is empty, and much
like the current stat_clear command, handles the zeroing of the stats
file when a "1" is echoed to the stats_clear file.

Patch 2 creates the symlink for stats from procfs to sysfs.

Patch 3 removes the now unused portions of procfs for stat.

Patch 4 consolidates the sysfs ops for dbg, stats, log.

Patch 5 allocates and deallocates per-fs stats structures and
sets up the sysfs entries for them. Add kobject and a pointer
to a per-cpu struct xfsstats. Modify the macros that manipulate
the stats accordingly.

Again, comments and questions are welcome.

Thanks-
Bill

<Prev in Thread] Current Thread [Next in Thread>