| To: | xfs@xxxxxxxxxxx |
|---|---|
| Subject: | [PATCH 1/4] metadump: include NULLFSINO check in inode copy code |
| From: | Brian Foster <bfoster@xxxxxxxxxx> |
| Date: | Mon, 23 Feb 2015 10:51:46 -0500 |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1424706709-21594-1-git-send-email-bfoster@xxxxxxxxxx> |
| References: | <1424706709-21594-1-git-send-email-bfoster@xxxxxxxxxx> |
The copy_ino() function includes a check for effectively NULL inode
numbers. It checks for 0 but does not include NULLFSINO. This leads to
spurious warnings in some instances. For example, copy_ino() is called
unconditionally for sb quota inodes from copy_sb_inodes(), values of
which can be NULLFSINO.
Check for NULLFSINO and return quietly from copy_ino().
Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx>
---
db/metadump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/db/metadump.c b/db/metadump.c
index 3eafac6..604fcf4 100644
--- a/db/metadump.c
+++ b/db/metadump.c
@@ -2112,7 +2112,7 @@ copy_ino(
int offset;
int rval = 0;
- if (ino == 0)
+ if (ino == 0 || ino == NULLFSINO)
return 1;
agno = XFS_INO_TO_AGNO(mp, ino);
--
1.9.3
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 2/4] metadump: check for non-zero inode alignment, Brian Foster |
|---|---|
| Next by Date: | [PATCH 3/4] xfsprogs: remove bitfield based superblock updates, Brian Foster |
| Previous by Thread: | [PATCH 2/4] metadump: check for non-zero inode alignment, Brian Foster |
| Next by Thread: | [PATCH 3/4] xfsprogs: remove bitfield based superblock updates, Brian Foster |
| Indexes: | [Date] [Thread] [Top] [All Lists] |