| To: | xfs@xxxxxxxxxxx |
|---|---|
| Subject: | [PATCH 0/2] xfs: more return cleanups |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Mon, 1 Dec 2014 15:20:06 +1100 |
| Delivered-to: | xfs@xxxxxxxxxxx |
Hi folks, I noticed a bit of inconsistency when reviewing the shift extent return cleanups that coccinelle flagged. The first was that the out_error labels were basically meaningless - it jsut returns the error, and we have much neater ways of doing that. Also, the logic flow through xfs_bmse_shift_one() jumped around all over the place - it can be done lots neater without any gotos at all, and is easier to read as a result. These patches apply on top of the for-next branch (the xfs-coccinelle-cleanups branch to be precise). Cheers, Dave. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 1/2] xfs: cleanup xfs_bmse_shift_one goto mess, Dave Chinner |
|---|---|
| Next by Date: | Re: Meeting, Dave Chinner |
| Previous by Thread: | [PATCH] xfs: fix premature enospc on inode allocation, Dave Chinner |
| Next by Thread: | [PATCH 2/2] xfs: cleanup xfs_bmse_merge returns, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |