| To: | linux-fsdevel@xxxxxxxxxxxxxxx |
|---|---|
| Subject: | [PATCH 2/2] ext3: Don't check quota format when there are no quota files |
| From: | Jan Kara <jack@xxxxxxx> |
| Date: | Fri, 10 Oct 2014 16:23:44 +0200 |
| Cc: | linux-ext4@xxxxxxxxxxxxxxx, Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, cluster-devel@xxxxxxxxxx, Steven Whitehouse <swhiteho@xxxxxxxxxx>, Mark Fasheh <mfasheh@xxxxxxxx>, Joel Becker <jlbec@xxxxxxxxxxxx>, ocfs2-devel@xxxxxxxxxxxxxx, reiserfs-devel@xxxxxxxxxxxxxxx, Jeff Mahoney <jeffm@xxxxxxx>, Dave Kleikamp <shaggy@xxxxxxxxxx>, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx, tytso@xxxxxxx, viro@xxxxxxxxxxxxxxxxxx, Jan Kara <jack@xxxxxxx>, stable@xxxxxxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1412951028-4085-1-git-send-email-jack@xxxxxxx> |
| References: | <1412951028-4085-1-git-send-email-jack@xxxxxxx> |
The check whether quota format is set even though there are no
quota files with journalled quota is pointless and it actually
makes it impossible to turn off journalled quotas (as there's
no way to unset journalled quota format). Just remove the check.
CC: stable@xxxxxxxxxxxxxxx
Signed-off-by: Jan Kara <jack@xxxxxxx>
---
fs/ext3/super.c | 7 -------
1 file changed, 7 deletions(-)
I'm going to queue this patch unless someone objects.
diff --git a/fs/ext3/super.c b/fs/ext3/super.c
index 622e88249024..2c42e739e3d1 100644
--- a/fs/ext3/super.c
+++ b/fs/ext3/super.c
@@ -1354,13 +1354,6 @@ set_qf_format:
"not specified.");
return 0;
}
- } else {
- if (sbi->s_jquota_fmt) {
- ext3_msg(sb, KERN_ERR, "error: journaled quota format "
- "specified with no journaling "
- "enabled.");
- return 0;
- }
}
#endif
return 1;
--
1.8.1.4
|
| Previous by Date: | [PATCH 1/2] vfs: Fix data corruption when blocksize < pagesize for mmaped data, Jan Kara |
|---|---|
| Next by Date: | [PATCH RESEND] vfs: Return EINVAL for default SEEK_HOLE, SEEK_DATA implementation, Jan Kara |
| Previous by Thread: | [PATCH 1/2] vfs: Fix data corruption when blocksize < pagesize for mmaped data, Jan Kara |
| Next by Thread: | [PATCH RESEND] vfs: Return EINVAL for default SEEK_HOLE, SEEK_DATA implementation, Jan Kara |
| Indexes: | [Date] [Thread] [Top] [All Lists] |