| To: | linux-fsdevel@xxxxxxxxxxxxxxx |
|---|---|
| Subject: | [PATCH] fs: Avoid userspace mounting anon_inodefs filesystem |
| From: | Jan Kara <jack@xxxxxxx> |
| Date: | Fri, 10 Oct 2014 16:23:22 +0200 |
| Cc: | linux-ext4@xxxxxxxxxxxxxxx, Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, cluster-devel@xxxxxxxxxx, Steven Whitehouse <swhiteho@xxxxxxxxxx>, Mark Fasheh <mfasheh@xxxxxxxx>, Joel Becker <jlbec@xxxxxxxxxxxx>, ocfs2-devel@xxxxxxxxxxxxxx, reiserfs-devel@xxxxxxxxxxxxxxx, Jeff Mahoney <jeffm@xxxxxxx>, Dave Kleikamp <shaggy@xxxxxxxxxx>, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx, tytso@xxxxxxx, viro@xxxxxxxxxxxxxxxxxx, Jan Kara <jack@xxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1412951028-4085-1-git-send-email-jack@xxxxxxx> |
| References: | <1412951028-4085-1-git-send-email-jack@xxxxxxx> |
anon_inodefs filesystem is a kernel internal filesystem userspace
shouldn't mess with. Remove registration of it so userspace cannot
even try to mount it (which would fail anyway because the filesystem is
MS_NOUSER).
This fixes an oops triggered by trinity when it tried mounting
anon_inodefs which overwrote anon_inode_inode pointer while other CPU
has been in anon_inode_getfile() between ihold() and d_instantiate().
Thus effectively creating dentry pointing to an inode without holding a
reference to it.
Reported-by: Sasha Levin <sasha.levin@xxxxxxxxxx>
Signed-off-by: Jan Kara <jack@xxxxxxx>
---
fs/anon_inodes.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/anon_inodes.c b/fs/anon_inodes.c
index 24084732b1d0..4b4543b8b894 100644
--- a/fs/anon_inodes.c
+++ b/fs/anon_inodes.c
@@ -177,9 +177,6 @@ static int __init anon_inode_init(void)
{
int error;
- error = register_filesystem(&anon_inode_fs_type);
- if (error)
- goto err_exit;
anon_inode_mnt = kern_mount(&anon_inode_fs_type);
if (IS_ERR(anon_inode_mnt)) {
error = PTR_ERR(anon_inode_mnt);
--
1.8.1.4
|
| Previous by Date: | [PATCH] ext4: Remove orphan list handling, Jan Kara |
|---|---|
| Next by Date: | [PATCH 1/2] ext4: Don't check quota format when there are no quota files, Jan Kara |
| Previous by Thread: | [PATCH] ext4: Remove orphan list handling, Jan Kara |
| Next by Thread: | [PATCH 1/2] ext4: Don't check quota format when there are no quota files, Jan Kara |
| Indexes: | [Date] [Thread] [Top] [All Lists] |