| To: | xfs@xxxxxxxxxxx |
|---|---|
| Subject: | [PATCH 3/8] libxfs: fix setup_cursor array allocation |
| From: | Eric Sandeen <sandeen@xxxxxxxxxx> |
| Date: | Sat, 26 Jan 2013 16:40:27 -0600 |
| Cc: | Eric Sandeen <sandeen@xxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1359240032-11576-1-git-send-email-sandeen@xxxxxxxxxx> |
| References: | <1359240032-11576-1-git-send-email-sandeen@xxxxxxxxxx> |
setup_cursor() wants an array of xfs_agbno_t's, but
it allocated a multiple of *pointers* to xfs_agbno_t's.
xfs_agbno_t is 4 bytes, so this is harmless other than
allocating twice as much memory as needed on a 64-bit
machine.
Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
---
repair/phase5.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/repair/phase5.c b/repair/phase5.c
index 7d5cd49..1f71cac 100644
--- a/repair/phase5.c
+++ b/repair/phase5.c
@@ -206,7 +206,7 @@ setup_cursor(xfs_mount_t *mp, xfs_agnumber_t agno,
bt_status_t *curs)
ASSERT(big_extent_len > 0);
- if ((curs->btree_blocks = malloc(sizeof(xfs_agblock_t *)
+ if ((curs->btree_blocks = malloc(sizeof(xfs_agblock_t)
* big_extent_len)) == NULL)
do_error(_("could not set up btree block array\n"));
--
1.7.1
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Looking For Supplier, Chris Jovan |
|---|---|
| Next by Date: | [PATCH 6/8] xfs_fsr: check strdup results properly in initallfs(), Eric Sandeen |
| Previous by Thread: | [PATCH 0/8] xfsprogs: misc small fixes, Eric Sandeen |
| Next by Thread: | [PATCH 6/8] xfs_fsr: check strdup results properly in initallfs(), Eric Sandeen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |