| To: | xfs@xxxxxxxxxxx |
|---|---|
| Subject: | [PATCH v2] xfstests: get return value in seek_sanity_test |
| From: | "wenqing.lz" <gnehzuil.liu@xxxxxxxxx> |
| Date: | Sun, 21 Oct 2012 21:15:09 +0800 |
| Cc: | Jeff Liu <jeff.liu@xxxxxxxxxx>, Zheng Liu <wenqing.lz@xxxxxxxxxx> |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=MAluVb+VcEajAxq7KG7refU71XYPk35mMit3S+1tEEM=; b=cgguU4u/17Y0MbDIFGSZzPTsab8MPoBLdPRxykonqQoT9C8VlkdeCuYIlfR8C+z9OK Xd0RyxnlNIXBqDG3KLyUxGrO7eychzLY6UInyLoKlr71epEHYPy2M2ZIyd0u7FrbAqrx tJtAtNnYkDE/6Pi8KrtlkhDPwkeO8MYxa+z84ZpzqHXXH8u/QcEFev4l+wBxmqXhlVGM 6LrE1tWkRWeuSEgW3scSqL95NnsXlNpgW7LyHslEsnvSLXXf6CCXV4Y4vlyrkFaj7Y+8 sHAgiPNkKwgm/zh6IjwOK66LYcuIwmvOpqvbrZE7MqhNM/tgJJ02YwjGGjsw3PzrNcy2 WDNw== |
From: Zheng Liu <wenqing.lz@xxxxxxxxxx>
In seek_sanity_test getting return value is missing. Thus we couldn't get the
result unless someone read the log file (e.g. # 285).
CC: Jeff Liu <jeff.liu@xxxxxxxxxx>
Signed-off-by: Zheng Liu <wenqing.lz@xxxxxxxxxx>
---
v2 <- v1:
* put return value check below the run_test()
Hi Jeff,
Could you please review this patch again? Thanks.
Regards,
Zheng
src/seek_sanity_test.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/seek_sanity_test.c b/src/seek_sanity_test.c
index 34f5508..3897f02 100644
--- a/src/seek_sanity_test.c
+++ b/src/seek_sanity_test.c
@@ -674,9 +674,9 @@ int main(int argc, char **argv)
goto out;
for (i = 0; i < numtests; ++i) {
+ ret = run_test(&seek_tests[i]);
if (ret)
- goto out;
- run_test(&seek_tests[i]);
+ break;
}
out:
--
1.7.12.rc2.18.g61b472e
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] xfstests: get return value in seek_sanity_test, Jie Liu |
|---|---|
| Next by Date: | Re: [PATCH v2] xfstests: get return value in seek_sanity_test, Jie Liu |
| Previous by Thread: | [PATCH] xfstests: get return value in seek_sanity_test, wenqing.lz |
| Next by Thread: | Re: [PATCH v2] xfstests: get return value in seek_sanity_test, Jie Liu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |