xfs
[Top] [All Lists]

Re: [Cluster-devel] [PATCH 3/4] gfs2: Use generic handlers of O_SYNC AIO

To: Jan Kara <jack@xxxxxxx>
Subject: Re: [Cluster-devel] [PATCH 3/4] gfs2: Use generic handlers of O_SYNC AIO DIO
From: Steven Whitehouse <swhiteho@xxxxxxxxxx>
Date: Mon, 13 Feb 2012 09:42:18 +0000
Cc: Jeff Moyer <jmoyer@xxxxxxxxxx>, cluster-devel@xxxxxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx
In-reply-to: <1328889842-23231-4-git-send-email-jack@xxxxxxx>
Organization: Red Hat UK Ltd
References: <1328889842-23231-1-git-send-email-jack@xxxxxxx> <1328889842-23231-4-git-send-email-jack@xxxxxxx>
Hi,

Acked-by: Steven Whitehouse <swhiteho@xxxxxxxxxx>

That looks ok to me,

Steve.

On Fri, 2012-02-10 at 17:04 +0100, Jan Kara wrote:
> Use generic handlers to queue fsync() when AIO DIO is completed for O_SYNC
> file.
> 
> Signed-off-by: Jan Kara <jack@xxxxxxx>
> ---
>  fs/gfs2/aops.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c
> index 501e5cb..9c381ff 100644
> --- a/fs/gfs2/aops.c
> +++ b/fs/gfs2/aops.c
> @@ -1034,7 +1034,7 @@ static ssize_t gfs2_direct_IO(int rw, struct kiocb 
> *iocb,
>  
>       rv = __blockdev_direct_IO(rw, iocb, inode, inode->i_sb->s_bdev, iov,
>                                 offset, nr_segs, gfs2_get_block_direct,
> -                               NULL, NULL, 0);
> +                               NULL, NULL, DIO_SYNC_WRITES);
>  out:
>       gfs2_glock_dq_m(1, &gh);
>       gfs2_holder_uninit(&gh);


<Prev in Thread] Current Thread [Next in Thread>