| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/4] xfs: make i_flags and unsigned long |
| From: | Alex Elder <aelder@xxxxxxx> |
| Date: | Wed, 26 Oct 2011 16:07:12 -0500 |
| Cc: | <xfs@xxxxxxxxxxx> |
| In-reply-to: | <20111019182420.712347469@xxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20111019182343.762985925@xxxxxxxxxxxxxxxxxxxxxx> <20111019182420.712347469@xxxxxxxxxxxxxxxxxxxxxx> |
| Reply-to: | <aelder@xxxxxxx> |
On Wed, 2011-10-19 at 14:23 -0400, Christoph Hellwig wrote: > To be used for bit wakeup i_flags needs to be an unsigned long or we'll > run into trouble on big endian systems. Beause of the 1-byte i_update > field right after it this actually causes a fairly large size increase > on its own (4 or 8 bytes), but that increase will be more than offset > by the next two patches. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> Looks fine. Reviewed-by: Alex Elder <aelder@xxxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [RFC PATCH 3/3] Add pquotaino to on-disk super block, Alex Elder |
|---|---|
| Next by Date: | Re: [PATCH 2/4] xfs: replace i_flock with a sleeping bitlock, Alex Elder |
| Previous by Thread: | [PATCH 1/4] xfs: make i_flags and unsigned long, Christoph Hellwig |
| Next by Thread: | [PATCH 3/4] xfs: replace i_pin_wait with a bit waitqueue, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |