| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/5] repair: handle repair of image files on large sector size filesystems |
| From: | Alex Elder <aelder@xxxxxxx> |
| Date: | Thu, 13 Oct 2011 04:57:49 -0500 |
| Cc: | <xfs@xxxxxxxxxxx> |
| In-reply-to: | <1318208915-14975-2-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1318208915-14975-1-git-send-email-david@xxxxxxxxxxxxx> <1318208915-14975-2-git-send-email-david@xxxxxxxxxxxxx> |
| Reply-to: | <aelder@xxxxxxx> |
On Mon, 2011-10-10 at 12:08 +1100, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > Because repair uses direct IO, it cannot do IO smaller than a sector > on the underlying device. When repairing a filesystem image, the > filesystem hosting the image may have a sector size larger than the > sector size of the image, and so single image sector reads and > writes will fail. > > To avoid this, when checking a file and there is a sector size > mismatch like this, turn off direct IO. While there, fix a compile > bug in the IO_DEBUG option for libxfs which was found during triage. > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> Looks good. Reviewed-by: Alex Elder <aelder@xxxxxxx> |
| Previous by Date: | Re: [PATCH 1/3] 263: Functional test case for the btrfs snapshot, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 2/5] repair: fix a valgrind reported error on i686, Alex Elder |
| Previous by Thread: | Re: [PATCH 1/5] repair: handle repair of image files on large sector size filesystems, Christoph Hellwig |
| Next by Thread: | [PATCH 5/5] repair: prevent blkmap extent count overflows, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |