| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfstests: 261: test failures caused by bogus mtab entries |
| From: | Alex Elder <aelder@xxxxxxx> |
| Date: | Thu, 6 Oct 2011 15:14:30 -0500 |
| Cc: | <xfs@xxxxxxxxxxx> |
| In-reply-to: | <20111006194913.GF13434@xxxxxxxxxxxxx> |
| References: | <201110032301.p93N1ISR023771@xxxxxxxxxxxxxxxxxxxxxx> <20111006194913.GF13434@xxxxxxxxxxxxx> |
| Reply-to: | <aelder@xxxxxxx> |
On Thu, 2011-10-06 at 15:49 -0400, Christoph Hellwig wrote:
> > +mtab=/proc/self/mounts
> > +if [ ! -r "${mtab}" ]; then
> > + mtab=/etc/mtab
> > + if [ ! -r "${mtab}" ]; then
> > + echo "warning: proceeding without use of mount table" >&2
> > + fi
> > +fi
>
> Just use /proc/self/mounts unconditionally, it's been there for a long
> time.
OK. I was just following the logic embedded in libxcmd
but I do prefer keeping it simple.
-Alex
> Otherwise looks good,
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Premature "No Space left on device" on XFS, Bernhard Schmidt |
|---|---|
| Next by Date: | [PATCH 0/9] a couple of buffer cache cleanups, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH] xfstests: 261: test failures caused by bogus mtab entries, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 1/2] xfs: Don't allocate new buffers on every call to _xfs_buf_find, Alex Elder |
| Indexes: | [Date] [Thread] [Top] [All Lists] |