| To: | Lukas Czerner <lczerner@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/2 v3] commit.rc: Add helper for math operation using bc |
| From: | Alex Elder <aelder@xxxxxxx> |
| Date: | Fri, 23 Sep 2011 10:00:42 -0500 |
| Cc: | <xfs@xxxxxxxxxxx> |
| In-reply-to: | <1316787311-23428-1-git-send-email-lczerner@xxxxxxxxxx> |
| References: | <1316787311-23428-1-git-send-email-lczerner@xxxxxxxxxx> |
| Reply-to: | <aelder@xxxxxxx> |
On Fri, 2011-09-23 at 16:15 +0200, Lukas Czerner wrote: > Sometimes using bash $(()) math might not be enough due to some > limitation (big numbers), so add helper using 'bc' program. For > now the results are only in perfect numbers (as in bash) since this is > all I need for now. > > Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx> Clever. This looks OK to me. I'd like to hear what others think. If it gets committed maybe we should revisit tests to see if using this function is warranted elsewhere. Boris Ranto's recent test (which I am on the verge of committing) in particular would be better the way it was originally posted, making use of this. Reviewed-by: Alex Elder <aelder@xxxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 2/2] Add test 257: Check proper FITRIM argument handling, Alex Elder |
|---|---|
| Next by Date: | Directory fsync, Zhu Han |
| Previous by Thread: | Re: [PATCH] Add test 257: Check proper FITRIM argument handling, Alex Elder |
| Next by Thread: | [PATCH v4] commit.rc: Add helper for math operation using bc, Lukas Czerner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |