| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 3/4] libxfs: handle short reads in libxfs_readbufr |
| From: | Alex Elder <aelder@xxxxxxx> |
| Date: | Wed, 21 Sep 2011 13:45:13 -0500 |
| Cc: | <xfs@xxxxxxxxxxx> |
| In-reply-to: | <20110920220030.576600914@xxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20110920215917.508421839@xxxxxxxxxxxxxxxxxxxxxx> <20110920220030.576600914@xxxxxxxxxxxxxxxxxxxxxx> |
| Reply-to: | <aelder@xxxxxxx> |
On Tue, 2011-09-20 at 17:59 -0400, Christoph Hellwig wrote: > Copy the code from libxfs_writebufr to handle short reads, and also > tidy up a formatting issue found in the libxfs_writebufr copy. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> That LIBXFS_B_EXIT == LIBXFS_EXIT_ON_FAILURE is a bad thing. It might be nice if libxfs_readbuf() and libxfs_writebuf() encoded that piece of information the same way (in b_flags). Anyway, what you have here looks good. Reviewed-by: Alex Elder <aelder@xxxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 2/4] libxfs: save errno before possibly overwriting it, Alex Elder |
|---|---|
| Next by Date: | Re: [PATCH 4/4] libxfs: add b_error, Alex Elder |
| Previous by Thread: | [PATCH 3/4] libxfs: handle short reads in libxfs_readbufr, Christoph Hellwig |
| Next by Thread: | [PATCH 2/4] libxfs: save errno before possibly overwriting it, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |