| To: | Bill Kendall <wkendall@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfsdump: allow multi-digit dialog prompts |
| From: | Alex Elder <aelder@xxxxxxx> |
| Date: | Tue, 9 Aug 2011 15:55:05 -0500 |
| Cc: | <xfs@xxxxxxxxxxx> |
| In-reply-to: | <1311784913-14191-1-git-send-email-wkendall@xxxxxxx> |
| References: | <1311784913-14191-1-git-send-email-wkendall@xxxxxxx> |
| Reply-to: | <aelder@xxxxxxx> |
On Wed, 2011-07-27 at 11:41 -0500, Bill Kendall wrote: > xfsdump issues a multiple-choice dialog in various circumstances > (e.g., media change request). An assert incorrectly limits this to > at most 8 choices even though the code can handle up to 9. Remove > the assert and change the code to handle multi-digit responses. > > Signed-off-by: Bill Kendall <wkendall@xxxxxxx> Sorry I didn't get to this sooner. I had a few minor quibbles, but I'm not going to even bother mentioning them. Your change looks good. I'll commit this for you. Reviewed-by: Alex Elder <aelder@xxxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: frequent kernel BUG and lockups - 2.6.39 + xfs_fsr, Marc Lehmann |
|---|---|
| Next by Date: | Re: frequent kernel BUG and lockups - 2.6.39 + xfs_fsr, Dave Chinner |
| Previous by Thread: | Re: [PATCH] xfsdump: allow multi-digit dialog prompts, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 1/4] xfsdump: remove conditional OPENMASKED code, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |