| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/4] xfs: remove confusing ail cursor wrapper |
| From: | Alex Elder <aelder@xxxxxxx> |
| Date: | Tue, 19 Jul 2011 18:03:50 -0500 |
| Cc: | <xfs@xxxxxxxxxxx> |
| In-reply-to: | <1310960419-9875-3-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1310960419-9875-1-git-send-email-david@xxxxxxxxxxxxx> <1310960419-9875-3-git-send-email-david@xxxxxxxxxxxxx> |
| Reply-to: | <aelder@xxxxxxx> |
On Mon, 2011-07-18 at 13:40 +1000, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > xfs_trans_ail_cursor_set() doesn't set the cursor to the current log > item, it sets it to the next item. There is already a function for > doing this - xfs_trans_ail_cursor_next() - and the _set function is > simply a two line wrapper. Remove it and open code the setting of > the cursor in the two locations that call it to remove the > confusion. > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> > Reviewed-by: Christoph Hellwig <hch@xxxxxx> I already reviewed this but I do see you did a tiny change or two. In any case, this (still) looks good. Reviewed-by: Alex Elder <aelder@xxxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 1/4] xfs: use a cursor for bulk AIL insertion, Alex Elder |
|---|---|
| Next by Date: | Re: [PATCH 3/4] xfs: convert AIL cursors to use struct list_head, Alex Elder |
| Previous by Thread: | [PATCH 2/4] xfs: remove confusing ail cursor wrapper, Dave Chinner |
| Next by Thread: | [PATCH 1/4] xfs: use a cursor for bulk AIL insertion, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |