Re: [PATCH 07/27] xfs: split xfs_itruncate

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 07/27] xfs: split xfs_itruncate_finish
From:	Alex Elder <aelder@xxxxxxx>
Date:	Wed, 6 Jul 2011 09:05:24 -0500
Cc:	<xfs@xxxxxxxxxxx>
In-reply-to:	<20110706081138.GA5361@xxxxxxxxxxxxx>
References:	<20110701094321.936534538@xxxxxxxxxxxxxxxxxxxxxx> <20110701094603.580931463@xxxxxxxxxxxxxxxxxxxxxx> <1309926958.3381.61.camel@doink> <20110706081138.GA5361@xxxxxxxxxxxxx>
Reply-to:	<aelder@xxxxxxx>

On Wed, 2011-07-06 at 04:11 -0400, Christoph Hellwig wrote:
> On Tue, Jul 05, 2011 at 11:35:58PM -0500, Alex Elder wrote:
> > The above comment (if true--I haven't really checked) seems
> > like something significant to preserve.
> 
> The comment at the goto label already catches the important bits of it.

I was referring to this:

    Aborting from this point might lose some blocks in
    the file system, but oh well.

I don't actually understand what the comment means, but if
you feel it isn't important that's fine.

                                        -Alex

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 11/27] xfs: kill the unused struct xfs_sync_work, (continued) [PATCH 11/27] xfs: kill the unused struct xfs_sync_work, Christoph Hellwig Re: [PATCH 11/27] xfs: kill the unused struct xfs_sync_work, Alex Elder [PATCH 05/27] xfs: always log timestamp updates in xfs_setattr_size, Christoph Hellwig [PATCH 09/27] xfs: fix filesystsem freeze race in xfs_trans_alloc, Christoph Hellwig Re: [PATCH 09/27] xfs: fix filesystsem freeze race in xfs_trans_alloc, Alex Elder [PATCH 12/27] xfs: factor out xfs_dir2_leaf_find_entry, Christoph Hellwig Re: [PATCH 12/27] xfs: factor out xfs_dir2_leaf_find_entry, Alex Elder [PATCH 07/27] xfs: split xfs_itruncate_finish, Christoph Hellwig Re: [PATCH 07/27] xfs: split xfs_itruncate_finish, Alex Elder Re: [PATCH 07/27] xfs: split xfs_itruncate_finish, Christoph Hellwig Re: [PATCH 07/27] xfs: split xfs_itruncate_finish, Alex Elder <= [PATCH 10/27] xfs: remove i_transp, Christoph Hellwig Re: [PATCH 10/27] xfs: remove i_transp, Alex Elder [PATCH 08/27] xfs: improve sync behaviour in the fact of aggressive dirtying, Christoph Hellwig Re: [PATCH 08/27] xfs: improve sync behaviour in the fact of aggressive dirtying, Alex Elder Re: [PATCH 08/27] xfs: improve sync behaviour in the fact of aggressive dirtying, Christoph Hellwig Re: [PATCH 08/27] xfs: improve sync behaviour in the fact of aggressive dirtying, Alex Elder [PATCH 15/27] xfs: cleanup the defintion of struct xfs_dir2_sf_entry, Christoph Hellwig Re: [PATCH 15/27] xfs: cleanup the defintion of struct xfs_dir2_sf_entry, Dave Chinner Re: [PATCH 15/27] xfs: cleanup the defintion of struct xfs_dir2_sf_entry, Alex Elder Re: [PATCH 15/27] xfs: cleanup the defintion of struct xfs_dir2_sf_entry, Christoph Hellwig

Previous by Date:	Re: [PATCH 00/27] patch queue for Linux 3.1, V2, Christoph Hellwig
Next by Date:	Re: [PATCH 08/27] xfs: improve sync behaviour in the fact of aggressive dirtying, Alex Elder
Previous by Thread:	Re: [PATCH 07/27] xfs: split xfs_itruncate_finish, Christoph Hellwig
Next by Thread:	[PATCH 10/27] xfs: remove i_transp, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: [PATCH 07/27] xfs: split xfs_itruncate_finish