Re: [PATCH 27/27] xfs: avoid a few disk cache flushes

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 27/27] xfs: avoid a few disk cache flushes
From:	Alex Elder <aelder@xxxxxxx>
Date:	Tue, 5 Jul 2011 23:11:24 -0500
Cc:	<xfs@xxxxxxxxxxx>
In-reply-to:	<20110701094607.799498339@xxxxxxxxxxxxxxxxxxxxxx>
References:	<20110701094321.936534538@xxxxxxxxxxxxxxxxxxxxxx> <20110701094607.799498339@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to:	<aelder@xxxxxxx>

On Fri, 2011-07-01 at 05:43 -0400, Christoph Hellwig wrote:
> There is no need for a pre-flush when doing writing the second part of a
> split log buffer, and if we are using an external log there is no need
> to do a full cache flush of the log device at all given that all writes
> to it use the FUA flag.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 14/27] xfs: kill struct xfs_dir2_sf, (continued) Re: [PATCH 14/27] xfs: kill struct xfs_dir2_sf, Alex Elder [PATCH 16/27] xfs: avoid usage of struct xfs_dir2_block, Christoph Hellwig Re: [PATCH 16/27] xfs: avoid usage of struct xfs_dir2_block, Dave Chinner Re: [PATCH 16/27] xfs: avoid usage of struct xfs_dir2_block, Christoph Hellwig Re: [PATCH 16/27] xfs: avoid usage of struct xfs_dir2_block, Alex Elder [PATCH 25/27] xfs: return the buffer locked from xfs_buf_get_uncached, Christoph Hellwig Re: [PATCH 25/27] xfs: return the buffer locked from xfs_buf_get_uncached, Dave Chinner Re: [PATCH 25/27] xfs: return the buffer locked from xfs_buf_get_uncached, Alex Elder [PATCH 27/27] xfs: avoid a few disk cache flushes, Christoph Hellwig Re: [PATCH 27/27] xfs: avoid a few disk cache flushes, Dave Chinner Re: [PATCH 27/27] xfs: avoid a few disk cache flushes, Alex Elder <= [PATCH 24/27] xfs: clean up buffer locking helpers, Christoph Hellwig Re: [PATCH 24/27] xfs: clean up buffer locking helpers, Dave Chinner Re: [PATCH 24/27] xfs: clean up buffer locking helpers, Alex Elder [PATCH 26/27] xfs: cleanup I/O-related buffer flags, Christoph Hellwig Re: [PATCH 26/27] xfs: cleanup I/O-related buffer flags, Alex Elder Re: [PATCH 26/27] xfs: cleanup I/O-related buffer flags, Christoph Hellwig Re: [PATCH 26/27] xfs: cleanup I/O-related buffer flags, Dave Chinner Re: [PATCH 26/27] xfs: cleanup I/O-related buffer flags, Christoph Hellwig [PATCH 18/27] xfs: avoid usage of struct xfs_dir2_data, Christoph Hellwig Re: [PATCH 18/27] xfs: avoid usage of struct xfs_dir2_data, Dave Chinner

Previous by Date:	Re: [PATCH 27/27] xfs: avoid a few disk cache flushes, Dave Chinner
Next by Date:	Re: [PATCH 07/27] xfs: split xfs_itruncate_finish, Alex Elder
Previous by Thread:	Re: [PATCH 27/27] xfs: avoid a few disk cache flushes, Dave Chinner
Next by Thread:	[PATCH 24/27] xfs: clean up buffer locking helpers, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]