Re: [PATCH 26/27] xfs: cleanup I/O-related buffer flags

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 26/27] xfs: cleanup I/O-related buffer flags
From:	Alex Elder <aelder@xxxxxxx>
Date:	Tue, 5 Jul 2011 23:09:15 -0500
Cc:	<xfs@xxxxxxxxxxx>
In-reply-to:	<20110701094607.536262104@xxxxxxxxxxxxxxxxxxxxxx>
References:	<20110701094321.936534538@xxxxxxxxxxxxxxxxxxxxxx> <20110701094607.536262104@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to:	<aelder@xxxxxxx>

On Fri, 2011-07-01 at 05:43 -0400, Christoph Hellwig wrote:
> Remove the unused and misnamed _XBF_RUN_QUEUES flag, rename XBF_LOG_BUFFER
> to the more fitting XBF_SYNCIO, and split XBF_ORDERED into XBF_FUA and
> XBF_FLUSH to allow more fine grained control over the bio flags.  Also
> cleanup processing of the flags in _xfs_buf_ioapply to make more sense,
> and renumber the sparse flag number space to group flags by purpose.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Interesting that _XBF_RUN_QUEUES was never actually used.
The new names are much more understandable.  Looks like
READ_META and WRITE_META are now effectively gone...

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 25/27] xfs: return the buffer locked from xfs_buf_get_uncached, (continued) [PATCH 25/27] xfs: return the buffer locked from xfs_buf_get_uncached, Christoph Hellwig Re: [PATCH 25/27] xfs: return the buffer locked from xfs_buf_get_uncached, Dave Chinner Re: [PATCH 25/27] xfs: return the buffer locked from xfs_buf_get_uncached, Alex Elder [PATCH 27/27] xfs: avoid a few disk cache flushes, Christoph Hellwig Re: [PATCH 27/27] xfs: avoid a few disk cache flushes, Dave Chinner Re: [PATCH 27/27] xfs: avoid a few disk cache flushes, Alex Elder [PATCH 24/27] xfs: clean up buffer locking helpers, Christoph Hellwig Re: [PATCH 24/27] xfs: clean up buffer locking helpers, Dave Chinner Re: [PATCH 24/27] xfs: clean up buffer locking helpers, Alex Elder [PATCH 26/27] xfs: cleanup I/O-related buffer flags, Christoph Hellwig Re: [PATCH 26/27] xfs: cleanup I/O-related buffer flags, Alex Elder <= Re: [PATCH 26/27] xfs: cleanup I/O-related buffer flags, Christoph Hellwig Re: [PATCH 26/27] xfs: cleanup I/O-related buffer flags, Dave Chinner Re: [PATCH 26/27] xfs: cleanup I/O-related buffer flags, Christoph Hellwig [PATCH 18/27] xfs: avoid usage of struct xfs_dir2_data, Christoph Hellwig Re: [PATCH 18/27] xfs: avoid usage of struct xfs_dir2_data, Dave Chinner Re: [PATCH 18/27] xfs: avoid usage of struct xfs_dir2_data, Christoph Hellwig Re: [PATCH 18/27] xfs: avoid usage of struct xfs_dir2_data, Alex Elder Re: [PATCH 18/27] xfs: avoid usage of struct xfs_dir2_data, Christoph Hellwig Re: [PATCH 00/27] patch queue for Linux 3.1, V2, Alex Elder Re: [PATCH 00/27] patch queue for Linux 3.1, V2, Christoph Hellwig

Previous by Date:	Re: XFS internal error (memory corruption), Dave Chinner
Next by Date:	Re: [PATCH 26/27] xfs: cleanup I/O-related buffer flags, Dave Chinner
Previous by Thread:	[PATCH 26/27] xfs: cleanup I/O-related buffer flags, Christoph Hellwig
Next by Thread:	Re: [PATCH 26/27] xfs: cleanup I/O-related buffer flags, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]