| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 25/27] xfs: return the buffer locked from xfs_buf_get_uncached |
| From: | Alex Elder <aelder@xxxxxxx> |
| Date: | Tue, 5 Jul 2011 22:57:25 -0500 |
| Cc: | <xfs@xxxxxxxxxxx> |
| In-reply-to: | <20110701094607.356791525@xxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20110701094321.936534538@xxxxxxxxxxxxxxxxxxxxxx> <20110701094607.356791525@xxxxxxxxxxxxxxxxxxxxxx> |
| Reply-to: | <aelder@xxxxxxx> |
On Fri, 2011-07-01 at 05:43 -0400, Christoph Hellwig wrote: > All other xfs_buf_get/read-like helpers return the buffer locked, make sure > xfs_buf_get_uncached isn't different for no reason. Half of the callers > already lock it directly after, and the others probably should also keep > it locked if only for consistency and beeing able to use xfs_buf_rele, > but I'll leave that for later. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Looks good. Reviewed-by: Alex Elder <aelder@xxxxxxx> |
| Previous by Date: | Re: [PATCH 23/27] xfs: remove the unused xfs_bufhash structure, Alex Elder |
|---|---|
| Next by Date: | Re: [PATCH 24/27] xfs: clean up buffer locking helpers, Alex Elder |
| Previous by Thread: | Re: [PATCH 25/27] xfs: return the buffer locked from xfs_buf_get_uncached, Dave Chinner |
| Next by Thread: | [PATCH 27/27] xfs: avoid a few disk cache flushes, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |