| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 15/27] xfs: cleanup the defintion of struct xfs_dir2_sf_entry |
| From: | Alex Elder <aelder@xxxxxxx> |
| Date: | Tue, 5 Jul 2011 22:33:31 -0500 |
| Cc: | <xfs@xxxxxxxxxxx> |
| In-reply-to: | <20110701094605.415405585@xxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20110701094321.936534538@xxxxxxxxxxxxxxxxxxxxxx> <20110701094605.415405585@xxxxxxxxxxxxxxxxxxxxxx> |
| Reply-to: | <aelder@xxxxxxx> |
On Fri, 2011-07-01 at 05:43 -0400, Christoph Hellwig wrote: > Remove the inumber member which is at a variable offset after the actual > name, and make name a real variable sized C99 array instead of the incorrect > one-sized array which confuses (not only) gcc. Based on this clean up > the helpers to calculate the entry size. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Why was the inode put after then name in the first place? Anyway, looks good. Reviewed-by: Alex Elder <aelder@xxxxxxx> |
| Previous by Date: | Re: [PATCH 14/27] xfs: kill struct xfs_dir2_sf, Alex Elder |
|---|---|
| Next by Date: | Re: [PATCH 16/27] xfs: avoid usage of struct xfs_dir2_block, Alex Elder |
| Previous by Thread: | Re: [PATCH 15/27] xfs: cleanup the defintion of struct xfs_dir2_sf_entry, Dave Chinner |
| Next by Thread: | Re: [PATCH 15/27] xfs: cleanup the defintion of struct xfs_dir2_sf_entry, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |