Re: [PATCH 13/27] xfs: cleanup shortform directory inode number handling

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 13/27] xfs: cleanup shortform directory inode number handling
From:	Alex Elder <aelder@xxxxxxx>
Date:	Tue, 5 Jul 2011 17:36:53 -0500
Cc:	<xfs@xxxxxxxxxxx>
In-reply-to:	<20110701094604.976400061@xxxxxxxxxxxxxxxxxxxxxx>
References:	<20110701094321.936534538@xxxxxxxxxxxxxxxxxxxxxx> <20110701094604.976400061@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to:	<aelder@xxxxxxx>

On Fri, 2011-07-01 at 05:43 -0400, Christoph Hellwig wrote:
> Refactor the shortform directory helpers that deal with the 32-bit vs
> 64-bit wide inode numbers into more sensible helpers, and kill the
> xfs_intino_t typedef that is now superflous.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looking at XFS_{GET,PUT}_DIR_INO{4,8}(), they could
maybe benefit from conversion to cpu_to_be32() and
friends.  They're only used in these few spots.

Looks good though.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 15/27] xfs: cleanup the defintion of struct xfs_dir2_sf_entry, (continued) [PATCH 15/27] xfs: cleanup the defintion of struct xfs_dir2_sf_entry, Christoph Hellwig Re: [PATCH 15/27] xfs: cleanup the defintion of struct xfs_dir2_sf_entry, Dave Chinner Re: [PATCH 15/27] xfs: cleanup the defintion of struct xfs_dir2_sf_entry, Alex Elder Re: [PATCH 15/27] xfs: cleanup the defintion of struct xfs_dir2_sf_entry, Christoph Hellwig [PATCH 17/27] xfs: kill struct xfs_dir2_block, Christoph Hellwig Re: [PATCH 17/27] xfs: kill struct xfs_dir2_block, Dave Chinner Re: [PATCH 17/27] xfs: kill struct xfs_dir2_block, Christoph Hellwig Re: [PATCH 17/27] xfs: kill struct xfs_dir2_block, Alex Elder Re: [PATCH 17/27] xfs: kill struct xfs_dir2_block, Alex Elder [PATCH 13/27] xfs: cleanup shortform directory inode number handling, Christoph Hellwig Re: [PATCH 13/27] xfs: cleanup shortform directory inode number handling, Alex Elder <= [PATCH 20/27] xfs: cleanup the defintion of struct xfs_dir2_data_entry, Christoph Hellwig Re: [PATCH 20/27] xfs: cleanup the defintion of struct xfs_dir2_data_entry, Dave Chinner Re: [PATCH 20/27] xfs: cleanup the defintion of struct xfs_dir2_data_entry, Alex Elder Re: [PATCH 20/27] xfs: cleanup the defintion of struct xfs_dir2_data_entry, Christoph Hellwig [PATCH 19/27] xfs: kill struct xfs_dir2_data, Christoph Hellwig Re: [PATCH 19/27] xfs: kill struct xfs_dir2_data, Dave Chinner Re: [PATCH 19/27] xfs: kill struct xfs_dir2_data, Alex Elder [PATCH 21/27] xfs: cleanup struct xfs_dir2_leaf, Christoph Hellwig Re: [PATCH 21/27] xfs: cleanup struct xfs_dir2_leaf, Dave Chinner Re: [PATCH 21/27] xfs: cleanup struct xfs_dir2_leaf, Alex Elder

Previous by Date:	Re: [PATCH 12/27] xfs: factor out xfs_dir2_leaf_find_entry, Alex Elder
Next by Date:	Re: [PATCH 03/27] xfs: use write_cache_pages for writeback clustering, Dave Chinner
Previous by Thread:	[PATCH 13/27] xfs: cleanup shortform directory inode number handling, Christoph Hellwig
Next by Thread:	[PATCH 20/27] xfs: cleanup the defintion of struct xfs_dir2_data_entry, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]