Re: [PATCH 12/27] xfs: factor out xfs_dir2_leaf_find

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 12/27] xfs: factor out xfs_dir2_leaf_find_entry
From:	Alex Elder <aelder@xxxxxxx>
Date:	Tue, 5 Jul 2011 17:36:44 -0500
Cc:	<xfs@xxxxxxxxxxx>
In-reply-to:	<20110701094604.795668656@xxxxxxxxxxxxxxxxxxxxxx>
References:	<20110701094321.936534538@xxxxxxxxxxxxxxxxxxxxxx> <20110701094604.795668656@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to:	<aelder@xxxxxxx>

On Fri, 2011-07-01 at 05:43 -0400, Christoph Hellwig wrote:
> plain text document attachment (xfs-factor-dir2-leaf-code)
> Add a new xfs_dir2_leaf_find_entry helper to factor out some duplicate code
> from xfs_dir2_leaf_addname xfs_dir2_leafn_add.  Found by Eric Sandeen using
> an automated code duplication checker.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Nice.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 03/27] xfs: work around bogus gcc warning in xfs_allocbt_init_cursor, (continued) [PATCH 03/27] xfs: work around bogus gcc warning in xfs_allocbt_init_cursor, Christoph Hellwig [PATCH 01/27] xfs: PF_FSTRANS should never be set in ->writepage, Christoph Hellwig [PATCH 04/27] xfs: split xfs_setattr, Christoph Hellwig [PATCH 06/27] xfs: kill xfs_itruncate_start, Christoph Hellwig [PATCH 11/27] xfs: kill the unused struct xfs_sync_work, Christoph Hellwig Re: [PATCH 11/27] xfs: kill the unused struct xfs_sync_work, Alex Elder [PATCH 05/27] xfs: always log timestamp updates in xfs_setattr_size, Christoph Hellwig [PATCH 09/27] xfs: fix filesystsem freeze race in xfs_trans_alloc, Christoph Hellwig Re: [PATCH 09/27] xfs: fix filesystsem freeze race in xfs_trans_alloc, Alex Elder [PATCH 12/27] xfs: factor out xfs_dir2_leaf_find_entry, Christoph Hellwig Re: [PATCH 12/27] xfs: factor out xfs_dir2_leaf_find_entry, Alex Elder <= [PATCH 07/27] xfs: split xfs_itruncate_finish, Christoph Hellwig Re: [PATCH 07/27] xfs: split xfs_itruncate_finish, Alex Elder Re: [PATCH 07/27] xfs: split xfs_itruncate_finish, Christoph Hellwig Re: [PATCH 07/27] xfs: split xfs_itruncate_finish, Alex Elder [PATCH 10/27] xfs: remove i_transp, Christoph Hellwig Re: [PATCH 10/27] xfs: remove i_transp, Alex Elder [PATCH 08/27] xfs: improve sync behaviour in the fact of aggressive dirtying, Christoph Hellwig Re: [PATCH 08/27] xfs: improve sync behaviour in the fact of aggressive dirtying, Alex Elder Re: [PATCH 08/27] xfs: improve sync behaviour in the fact of aggressive dirtying, Christoph Hellwig Re: [PATCH 08/27] xfs: improve sync behaviour in the fact of aggressive dirtying, Alex Elder

Previous by Date:	Re: [PATCH 11/27] xfs: kill the unused struct xfs_sync_work, Alex Elder
Next by Date:	Re: [PATCH 13/27] xfs: cleanup shortform directory inode number handling, Alex Elder
Previous by Thread:	[PATCH 12/27] xfs: factor out xfs_dir2_leaf_find_entry, Christoph Hellwig
Next by Thread:	[PATCH 07/27] xfs: split xfs_itruncate_finish, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: [PATCH 12/27] xfs: factor out xfs_dir2_leaf_find_entry