Re: [PATCH 02/27] xfs: re-enable non-blocking behaviour in xfs_map

xfs

Re: [PATCH 02/27] xfs: re-enable non-blocking behaviour in xfs_map_block

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 02/27] xfs: re-enable non-blocking behaviour in xfs_map_blocks
From:	Alex Elder <aelder@xxxxxxx>
Date:	Tue, 5 Jul 2011 17:35:19 -0500
Cc:	<xfs@xxxxxxxxxxx>
In-reply-to:	<20110701094602.465074143@xxxxxxxxxxxxxxxxxxxxxx>
References:	<20110701094321.936534538@xxxxxxxxxxxxxxxxxxxxxx> <20110701094602.465074143@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to:	<aelder@xxxxxxx>

On Fri, 2011-07-01 at 05:43 -0400, Christoph Hellwig wrote:
> The non-blockig behaviour in xfs_map_blocks currently is conditional on
> having both the WB_SYNC_NONE sync_mode and the nonblocking flag set.
> The latter used to be used by both pdflush, kswapd and a few other places
> in older kernels, but has been fading out starting with the introduction
> of the per-bdi flusher threads.
> 
> Enable the non-blocking behaviour for all WB_SYNC_NONE calls to get back
> the behaviour we want.

The subject line should refer to xfs_vm_writepage()
(not xfs_map_blocks()).  Unless I hear otherwise I
will plan to change that for you.

Other than that this looks OK to me.

Signed-off-by: Alex Elder <aelder@xxxxxxx>


> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 00/27] patch queue for Linux 3.1, V2, Christoph Hellwig [PATCH 02/27] xfs: re-enable non-blocking behaviour in xfs_map_blocks, Christoph Hellwig Re: [PATCH 02/27] xfs: re-enable non-blocking behaviour in xfs_map_blocks, Alex Elder <= Re: [PATCH 02/27] xfs: re-enable non-blocking behaviour in xfs_map_blocks, Christoph Hellwig Re: [PATCH 02/27] xfs: re-enable non-blocking behaviour in xfs_map_blocks, Alex Elder [PATCH 03/27] xfs: work around bogus gcc warning in xfs_allocbt_init_cursor, Christoph Hellwig [PATCH 01/27] xfs: PF_FSTRANS should never be set in ->writepage, Christoph Hellwig [PATCH 04/27] xfs: split xfs_setattr, Christoph Hellwig [PATCH 06/27] xfs: kill xfs_itruncate_start, Christoph Hellwig [PATCH 11/27] xfs: kill the unused struct xfs_sync_work, Christoph Hellwig Re: [PATCH 11/27] xfs: kill the unused struct xfs_sync_work, Alex Elder [PATCH 05/27] xfs: always log timestamp updates in xfs_setattr_size, Christoph Hellwig [PATCH 09/27] xfs: fix filesystsem freeze race in xfs_trans_alloc, Christoph Hellwig

Previous by Date:	Re: [PATCH 03/27] xfs: use write_cache_pages for writeback clustering, Dave Chinner
Next by Date:	Re: [PATCH 08/27] xfs: improve sync behaviour in the fact of aggressive dirtying, Alex Elder
Previous by Thread:	[PATCH 02/27] xfs: re-enable non-blocking behaviour in xfs_map_blocks, Christoph Hellwig
Next by Thread:	Re: [PATCH 02/27] xfs: re-enable non-blocking behaviour in xfs_map_blocks, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]