Re: [PATCH 05/27] xfs: work around bogus gcc warning in xfs_allocbt

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 05/27] xfs: work around bogus gcc warning in xfs_allocbt_init_cursor
From:	Alex Elder <aelder@xxxxxxx>
Date:	Wed, 29 Jun 2011 17:13:09 -0500
Cc:	<xfs@xxxxxxxxxxx>
In-reply-to:	<20110629140337.417478423@xxxxxxxxxxxxxxxxxxxxxx>
References:	<20110629140109.003209430@xxxxxxxxxxxxxxxxxxxxxx> <20110629140337.417478423@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to:	<aelder@xxxxxxx>

On Wed, 2011-06-29 at 10:01 -0400, Christoph Hellwig wrote:
> plain text document attachment
> (xfs-fix-xfs_allocbt_init_cursor-warning)
> GCC 4.6 complains about an array subscript is above array bounds when
> using the btree index to index into the agf_levels array.  The only
> two indices passed in are 0 and 1, and we have an assert insuring that.
> 
> Replace the trick of using the array index directly with using constants
> in the already existing branch for assigning the XFS_BTREE_LASTREC_UPDATE
> flag.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 02/27] xfs: remove the unused ilock_nowait codepath in writepage, (continued) Re: [PATCH 02/27] xfs: remove the unused ilock_nowait codepath in writepage, Dave Chinner Re: [PATCH 02/27] xfs: remove the unused ilock_nowait codepath in writepage, Christoph Hellwig [PATCH 07/27] xfs: always log timestamp updates in xfs_setattr_size, Christoph Hellwig Re: [PATCH 07/27] xfs: always log timestamp updates in xfs_setattr_size, Alex Elder Re: [PATCH 07/27] xfs: always log timestamp updates in xfs_setattr_size, Dave Chinner Re: [PATCH 07/27] xfs: always log timestamp updates in xfs_setattr_size, Christoph Hellwig [PATCH 04/27] xfs: cleanup xfs_add_to_ioend, Christoph Hellwig Re: [PATCH 04/27] xfs: cleanup xfs_add_to_ioend, Alex Elder Re: [PATCH 04/27] xfs: cleanup xfs_add_to_ioend, Dave Chinner [PATCH 05/27] xfs: work around bogus gcc warning in xfs_allocbt_init_cursor, Christoph Hellwig Re: [PATCH 05/27] xfs: work around bogus gcc warning in xfs_allocbt_init_cursor, Alex Elder <= [PATCH 01/27] xfs: PF_FSTRANS should never be set in ->writepage, Christoph Hellwig Re: [PATCH 01/27] xfs: PF_FSTRANS should never be set in ->writepage, Dave Chinner [PATCH 08/27] xfs: kill xfs_itruncate_start, Christoph Hellwig Re: [PATCH 08/27] xfs: kill xfs_itruncate_start, Alex Elder [PATCH 10/27] xfs: improve sync behaviour in the fact of aggressive dirtying, Christoph Hellwig Re: [PATCH 10/27] xfs: improve sync behaviour in the fact of aggressive dirtying, Dave Chinner [PATCH 03/27] xfs: use write_cache_pages for writeback clustering, Christoph Hellwig Re: [PATCH 03/27] xfs: use write_cache_pages for writeback clustering, Dave Chinner Re: [PATCH 03/27] xfs: use write_cache_pages for writeback clustering, Dave Chinner Re: [PATCH 03/27] xfs: use write_cache_pages for writeback clustering, Christoph Hellwig

Previous by Date:	Re: [PATCH 04/27] xfs: cleanup xfs_add_to_ioend, Alex Elder
Next by Date:	Re: [PATCH 06/27] xfs: split xfs_setattr, Alex Elder
Previous by Thread:	[PATCH 05/27] xfs: work around bogus gcc warning in xfs_allocbt_init_cursor, Christoph Hellwig
Next by Thread:	[PATCH 01/27] xfs: PF_FSTRANS should never be set in ->writepage, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: [PATCH 05/27] xfs: work around bogus gcc warning in xfs_allocbt_init