Re: [PATCH 04/27] xfs: cleanup xfs_add_to

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 04/27] xfs: cleanup xfs_add_to_ioend
From:	Alex Elder <aelder@xxxxxxx>
Date:	Wed, 29 Jun 2011 17:13:00 -0500
Cc:	<xfs@xxxxxxxxxxx>
In-reply-to:	<20110629140337.137341800@xxxxxxxxxxxxxxxxxxxxxx>
References:	<20110629140109.003209430@xxxxxxxxxxxxxxxxxxxxxx> <20110629140337.137341800@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to:	<aelder@xxxxxxx>

On Wed, 2011-06-29 at 10:01 -0400, Christoph Hellwig wrote:
> plain text document attachment (xfs-cleanup-xfs_add_to_ioend)
> Pass the writeback context to xfs_add_to_ioend to make the ioend
> chain manipulations self-contained in this function.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good.  I much prefer what you've done to how
it was before.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

PS  I still have to review patch 3 in this series.

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 00/27] patch queue for Linux 3.1, Christoph Hellwig [PATCH 02/27] xfs: remove the unused ilock_nowait codepath in writepage, Christoph Hellwig Re: [PATCH 02/27] xfs: remove the unused ilock_nowait codepath in writepage, Dave Chinner Re: [PATCH 02/27] xfs: remove the unused ilock_nowait codepath in writepage, Dave Chinner Re: [PATCH 02/27] xfs: remove the unused ilock_nowait codepath in writepage, Christoph Hellwig [PATCH 07/27] xfs: always log timestamp updates in xfs_setattr_size, Christoph Hellwig Re: [PATCH 07/27] xfs: always log timestamp updates in xfs_setattr_size, Alex Elder Re: [PATCH 07/27] xfs: always log timestamp updates in xfs_setattr_size, Dave Chinner Re: [PATCH 07/27] xfs: always log timestamp updates in xfs_setattr_size, Christoph Hellwig [PATCH 04/27] xfs: cleanup xfs_add_to_ioend, Christoph Hellwig Re: [PATCH 04/27] xfs: cleanup xfs_add_to_ioend, Alex Elder <= Re: [PATCH 04/27] xfs: cleanup xfs_add_to_ioend, Dave Chinner [PATCH 05/27] xfs: work around bogus gcc warning in xfs_allocbt_init_cursor, Christoph Hellwig Re: [PATCH 05/27] xfs: work around bogus gcc warning in xfs_allocbt_init_cursor, Alex Elder [PATCH 01/27] xfs: PF_FSTRANS should never be set in ->writepage, Christoph Hellwig Re: [PATCH 01/27] xfs: PF_FSTRANS should never be set in ->writepage, Dave Chinner [PATCH 08/27] xfs: kill xfs_itruncate_start, Christoph Hellwig Re: [PATCH 08/27] xfs: kill xfs_itruncate_start, Alex Elder [PATCH 10/27] xfs: improve sync behaviour in the fact of aggressive dirtying, Christoph Hellwig Re: [PATCH 10/27] xfs: improve sync behaviour in the fact of aggressive dirtying, Dave Chinner [PATCH 03/27] xfs: use write_cache_pages for writeback clustering, Christoph Hellwig

Previous by Date:	[PATCH] xfs: Remove the second parameter to xfs_sb_count(), Chandra Seetharaman
Next by Date:	Re: [PATCH 05/27] xfs: work around bogus gcc warning in xfs_allocbt_init_cursor, Alex Elder
Previous by Thread:	[PATCH 04/27] xfs: cleanup xfs_add_to_ioend, Christoph Hellwig
Next by Thread:	Re: [PATCH 04/27] xfs: cleanup xfs_add_to_ioend, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: [PATCH 04/27] xfs: cleanup xfs_add_to_ioend