| To: | <sekharan@xxxxxxxxxx> |
|---|---|
| Subject: | Re: sbcount comment change |
| From: | Alex Elder <aelder@xxxxxxx> |
| Date: | Wed, 29 Jun 2011 13:36:32 -0500 |
| Cc: | <xfs@xxxxxxxxxxx> |
| In-reply-to: | <1309366188.5505.6215.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
| References: | <1309366188.5505.6215.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
| Reply-to: | <aelder@xxxxxxx> |
On Wed, 2011-06-29 at 09:49 -0700, Chandra Seetharaman wrote:
> Hi Alex,
>
> Does this look fine ?
Yes. But it's small enough that I think you should just
include this change with another change (especially if you
decide to drop the "sync" flag from this function as I
suggested).
-Alex
> --------------
> @@ -1568,18 +1568,14 @@ xfs_fs_writable(xfs_mount_t *mp)
> /*
> * xfs_log_sbcount
> *
> - * Called either periodically to keep the on disk superblock values
> - * roughly up to date or from unmount to make sure the values are
> - * correct on a clean unmount.
> + * Sync the superblock counters to disk.
> *
> * Note this code can be called during the process of freezing, so
> - * we may need to use the transaction allocator which does not not
> + * we may need to use the transaction allocator which does not
> * block when the transaction subsystem is in its frozen state.
> */
> ----------------
>
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Fwd: PATCH: remove varibale that serve no purpose in xfs_alloc_ag_vextent_exact()], Alex Elder |
|---|---|
| Next by Date: | Re: [PATCH] xfs: replace bp->flags usage with predefined macros, Chandra Seetharaman |
| Previous by Thread: | Re: [Fwd: PATCH: remove varibale that serve no purpose in xfs_alloc_ag_vextent_exact()], Alex Elder |
| Next by Thread: | [PATCH] xfs: Remove the second parameter to xfs_sb_count(), Chandra Seetharaman |
| Indexes: | [Date] [Thread] [Top] [All Lists] |