Re: [PATCH 2/9 v2] xfs: remove if

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 2/9 v2] xfs: remove if_lastex
From:	Alex Elder <aelder@xxxxxxx>
Date:	Tue, 24 May 2011 20:14:27 -0500
Cc:	<xfs@xxxxxxxxxxx>
In-reply-to:	<20110523085253.GA15985@xxxxxxxxxxxxx>
References:	<20110511150402.258164661@xxxxxxxxxxxxxxxxxxxxxx> <20110511150711.549194744@xxxxxxxxxxxxxxxxxxxxxx> <20110523085253.GA15985@xxxxxxxxxxxxx>
Reply-to:	<aelder@xxxxxxx>

On Mon, 2011-05-23 at 04:52 -0400, Christoph Hellwig wrote:
> The if_lastex field in struct xfs_ifork is only used as a temporary index
> during xfs_bmapi and xfs_bunmapi.  Instead of using the inode fork to store
> it keep it local in the callchain.  Fortunately this is very easy as
> we already pass a stack copy of it down the whole chain which can simplify
> be changed to be passed by reference.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 3/9] xfs: correctly decrement the extent buffer index in xfs_bmap_del_extent, (continued) Re: [PATCH 3/9] xfs: correctly decrement the extent buffer index in xfs_bmap_del_extent, Lachlan McIlroy Re: [PATCH 3/9] xfs: correctly decrement the extent buffer index in xfs_bmap_del_extent, Alex Elder [PATCH 9/9] xfs: check for valid indices in xfs_iext_get_ext and xfs_iext_idx_to_irec, Christoph Hellwig Re: [PATCH 9/9] xfs: check for valid indices in xfs_iext_get_ext and xfs_iext_idx_to_irec, Lachlan McIlroy Re: [PATCH 9/9] xfs: check for valid indices in xfs_iext_get_ext and xfs_iext_idx_to_irec, Alex Elder [PATCH 1/9] xfs: remove the unused XFS_BMAPI_RSVBLOCKS flag, Christoph Hellwig Re: [PATCH 1/9] xfs: remove the unused XFS_BMAPI_RSVBLOCKS flag, Alex Elder [PATCH 2/9] xfs: remove if_lastex, Christoph Hellwig Re: [PATCH 2/9] xfs: remove if_lastex, Alex Elder [PATCH 2/9 v2] xfs: remove if_lastex, Christoph Hellwig Re: [PATCH 2/9 v2] xfs: remove if_lastex, Alex Elder <= [PATCH 4/9] xfs: do not use unchecked extent indices in xfs_bmap_add_extent_, Christoph Hellwig* Re: [PATCH 4/9] xfs: do not use unchecked extent indices in xfs_bmap_add_extent_, Lachlan McIlroy* Re: [PATCH 4/9] xfs: do not use unchecked extent indices in xfs_bmap_add_extent_, Alex Elder*

Previous by Date:	Re: [PATCH 9/9] xfs: check for valid indices in xfs_iext_get_ext and xfs_iext_idx_to_irec, Alex Elder
Next by Date:	[XFS updates] XFS development tree branch, master, updated. v2.6.38-10136-g55a7bc5, xfs
Previous by Thread:	[PATCH 2/9 v2] xfs: remove if_lastex, Christoph Hellwig
Next by Thread:	[PATCH 4/9] xfs: do not use unchecked extent indices in xfs_bmap_add_extent_, Christoph Hellwig*
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: [PATCH 2/9 v2] xfs: remove if_lastex