| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 6/9] xfs: do not use unchecked extent indices in xfs_bunmapi |
| From: | Alex Elder <aelder@xxxxxxx> |
| Date: | Tue, 24 May 2011 19:31:42 -0500 |
| Cc: | <xfs@xxxxxxxxxxx> |
| In-reply-to: | <20110511150712.421348825@xxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20110511150402.258164661@xxxxxxxxxxxxxxxxxxxxxx> <20110511150712.421348825@xxxxxxxxxxxxxxxxxxxxxx> |
| Reply-to: | <aelder@xxxxxxx> |
On Wed, 2011-05-11 at 11:04 -0400, Christoph Hellwig wrote: > Make sure to only call xfs_iext_get_ext after we've validate the extent index > when moving on to the next index in xfs_bunmapi. Also remove the old > workaround for too large indices that has been superceeded by the proper > fix in xfs_bmap_del_extent. > > Based on an earlier patch from Lachlan McIlroy. This looks good, but I'd like to see this patch and patch 3/9 re-done to more cleanly separate their purposes (as I mentioned in my comments on patch 3). Reviewed-by: Alex Elder <aelder@xxxxxxx> > Signed-off-by: Christoph Hellwig <hch@xxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 5/9] xfs: do not use unchecked extent indices in xfs_bmapi, Alex Elder |
|---|---|
| Next by Date: | Re: [PATCH 7/9] xfs: do not do pointer arithmetics on extent records, Alex Elder |
| Previous by Thread: | Re: [PATCH 6/9] xfs: do not use unchecked extent indices in xfs_bunmapi, Lachlan McIlroy |
| Next by Thread: | [PATCH 5/9] xfs: do not use unchecked extent indices in xfs_bmapi, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |