xfs
[Top] [All Lists]

Re: [PATCH] xfstests: fix a few build warnings

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: fix a few build warnings
From: Alex Elder <aelder@xxxxxxx>
Date: Thu, 10 Mar 2011 16:16:53 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110310172418.GA13390@xxxxxxxxxxxxx>
References: <201103041937.p24JbVtP004804@xxxxxxxxxxxxxxxxxxxxxx> <20110310172418.GA13390@xxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Thu, 2011-03-10 at 12:24 -0500, Christoph Hellwig wrote:
> >  lio_random_methods(long curr_mask)
> >  {
> >      int mask=0;
> > -    long random_bit();
> > +    long random_bit(long);
> 
> This should use the prototype from include/random_range.h instead.
> 
> Otherwise looks good to me,
> 
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

I should have done that.  Already committed though.


<Prev in Thread] Current Thread [Next in Thread>