Re: [PATCH 12/12] xfs: kill support/debug.[ch]

xfs

Re: [PATCH 12/12] xfs: kill support/debug.[ch]

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 12/12] xfs: kill support/debug.[ch]
From:	Alex Elder <aelder@xxxxxxx>
Date:	Tue, 11 Jan 2011 22:48:53 -0600
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1294792553-8378-13-git-send-email-david@xxxxxxxxxxxxx>
References:	<1294792553-8378-1-git-send-email-david@xxxxxxxxxxxxx> <1294792553-8378-13-git-send-email-david@xxxxxxxxxxxxx>
Reply-to:	aelder@xxxxxxx

On Wed, 2011-01-12 at 11:35 +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> The remaining functionality in debug.[ch] is effectively just assert
> handling, conditional debug definitions and hex dumping. The hex
> dumping and assert function can be moved into the new printk module,
> while the rest can be moved into top-level header files. This allows
> fs/xfs/support/debug.[ch] to be completely removed from the
> codebase.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
>  fs/xfs/Makefile               |    1 -
>  fs/xfs/linux-2.6/xfs_linux.h  |   21 +++++++++++++++++++

You need to delete the #include <support/debug.h>
that remains in linux-2.6/xfs_linux.h too.

                                        -Alex

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[RFC, PATCH 0/12] xfs: rework error logging infrastructure, Dave Chinner [PATCH 04/12] xfs: Convert xlog_warn to new logging interface, Dave Chinner Re: [PATCH 04/12] xfs: Convert xlog_warn to new logging interface, Alex Elder [PATCH 10/12] xfs: convert the quota debug prints to new API, Dave Chinner [PATCH 12/12] xfs: kill support/debug.[ch], Dave Chinner Re: [PATCH 12/12] xfs: kill support/debug.[ch], Alex Elder <= Re: [PATCH 12/12] xfs: kill support/debug.[ch], Christoph Hellwig [PATCH 02/12] xfs: introduce new logging API., Dave Chinner [PATCH 08/12] xfs: convert xfs_fs_cmn_err to new error logging API, Dave Chinner [PATCH 11/12] xfs: Convert remaining cmn_err() callers to new API, Dave Chinner [PATCH 09/12] xfs: rename xfs_cmn_err_fsblock_zero(), Dave Chinner [PATCH 07/12] xfs: kill xfs_fs_mount_cmn_err() macro, Dave Chinner Re: [PATCH 07/12] xfs: kill xfs_fs_mount_cmn_err() macro, Christoph Hellwig Re: [PATCH 07/12] xfs: kill xfs_fs_mount_cmn_err() macro, Dave Chinner Re: [PATCH 07/12] xfs: kill xfs_fs_mount_cmn_err() macro, Christoph Hellwig [PATCH 05/12] xfs: convert xfs_cmn_err to xfs_alert_tag, Dave Chinner

Previous by Date:	Re: [RFC, PATCH 0/12] xfs: rework error logging infrastructure, Alex Elder
Next by Date:	[PATCH] [RFC] xfs: stop using the page cache to back the buffer cache, Dave Chinner
Previous by Thread:	[PATCH 12/12] xfs: kill support/debug.[ch], Dave Chinner
Next by Thread:	Re: [PATCH 12/12] xfs: kill support/debug.[ch], Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]