| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [RFC, PATCH 0/12] xfs: rework error logging infrastructure |
| From: | Alex Elder <aelder@xxxxxxx> |
| Date: | Tue, 11 Jan 2011 22:16:29 -0600 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1294792553-8378-1-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1294792553-8378-1-git-send-email-david@xxxxxxxxxxxxx> |
| Reply-to: | aelder@xxxxxxx |
On Wed, 2011-01-12 at 11:35 +1100, Dave Chinner wrote: > This series completely reworks the cmn_err logging infrastructure > by replacing it with a simple, consistent API that can be used everwhere. > IOWs, this series replaces the various cmn_err APIs: . . . I reviewed the whole series, and offered a correction on just one thing. I might quibble with the indentation of some of the format strings here or there, but I didn't bother, there sometimes is no nice way to do those. I personally like the result a lot, it's a lot cleaner and easier on the eyes. In any case, you say it's an RFC but I'm OK with it. I'm just starting to test with it but you can consider the whole series reviewed by me. Reviewed-by: Alex Elder <aelder@xxxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 04/12] xfs: Convert xlog_warn to new logging interface, Alex Elder |
|---|---|
| Next by Date: | Re: [PATCH 12/12] xfs: kill support/debug.[ch], Alex Elder |
| Previous by Thread: | [PATCH 03/12] xfs: Convert linux-2.6/ files to new logging interface, Dave Chinner |
| Next by Thread: | Re: [RFC, PATCH 0/12] xfs: rework error logging infrastructure, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |