Re: [PATCH 1/8] xfs: ensure sync write errors are returned

[Alex Elder <aelder@xxxxxxx>]

On Tue, 2011-01-04 at 15:48 +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> xfs_file_aio_write() only returns the error from synchronous
> flushing of the data and inode if error == 0. At the point where
> error is being checked, it is guaranteed to be > 0. Therefore any
> errors returned by the data or fsync flush will never be returned.
> Fix the checks so we overwrite the current error once and only if an
> error really occurred.
> 

This looks good.  You improved it a lot by
fixing up the bizarre "error" logic.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
>  fs/xfs/linux-2.6/xfs_file.c |   51 
> +++++++++++++++++++++----------------------
>  1 files changed, 25 insertions(+), 26 deletions(-)