| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/5] percpu_counter: fix test in __percpu_counter_add_unless_lt() |
| From: | Alex Elder <aelder@xxxxxxx> |
| Date: | Wed, 29 Dec 2010 15:49:20 -0600 |
| Cc: | XFS Mailing List <xfs@xxxxxxxxxxx> |
| In-reply-to: | <1293656188.1961.470.camel@doink> |
| References: | <1293076575.2408.425.camel@doink> <20101223060652.GE18264@dastard> <1293656188.1961.470.camel@doink> |
| Reply-to: | aelder@xxxxxxx |
On Wed, 2010-12-29 at 14:56 -0600, Alex Elder wrote:
> if (new_count >= threshold) {
> ret = new_count > threshold;
> fbc->count = fbc_count + amount;
> }
> spin_unlock(&fbc->lock);
>
> return ret;
> }
I obviously didn't test the code I sent, but
you get what I mean... Here is the way one of
the lines above should look:
fbc->count = fbc->count + amount;
Or even better:
fbc->count += amount;
-Alex
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 1/5] percpu_counter: fix test in __percpu_counter_add_unless_lt(), Alex Elder |
|---|---|
| Next by Date: | Re: xfs: add FITRIM support, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH 1/5] percpu_counter: fix test in __percpu_counter_add_unless_lt(), Alex Elder |
| Next by Thread: | Re: [PATCH 1/5] percpu_counter: fix test in __percpu_counter_add_unless_lt(), Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |