Re: [PATCH 13/18] xfs: split out inode walk inode grabbing

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 13/18] xfs: split out inode walk inode grabbing
From:	Alex Elder <aelder@xxxxxxx>
Date:	Mon, 27 Sep 2010 10:58:56 -0500
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1285552073-14663-14-git-send-email-david@xxxxxxxxxxxxx>
References:	<1285552073-14663-1-git-send-email-david@xxxxxxxxxxxxx> <1285552073-14663-14-git-send-email-david@xxxxxxxxxxxxx>
Reply-to:	aelder@xxxxxxx

On Mon, 2010-09-27 at 11:47 +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> When doing read side inode cache walks, the code to validate and
> grab an inode is common to all callers. Split it out of the execute
> callbacks in preparation for batching lookups. Similarly, split out
> the inode reference dropping from the execute callbacks into the
> main lookup look to be symmetric with the grab.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 08/18] xfs: store xfs_mount in the buftarg instead of in the xfs_buf, (continued) [PATCH 08/18] xfs: store xfs_mount in the buftarg instead of in the xfs_buf, Dave Chinner [PATCH 05/18] xfs: don't use vfs writeback for pure metadata modifications, Dave Chinner Re: [PATCH 05/18] xfs: don't use vfs writeback for pure metadata modifications, Christoph Hellwig [PATCH 09/18] xfs: kill XBF_FS_MANAGED buffers, Dave Chinner [PATCH 07/18] xfs: introduced uncached buffer read primitve, Dave Chinner [PATCH 11/18] xfs: remove buftarg hash for external devices, Dave Chinner [PATCH 01/18] xfs: force background CIL push under sustained load, Dave Chinner [PATCH 10/18] xfs: use unhashed buffers for size checks, Dave Chinner [PATCH 12/18] xfs: split inode AG walking into separate code for reclaim, Dave Chinner [PATCH 13/18] xfs: split out inode walk inode grabbing, Dave Chinner Re: [PATCH 13/18] xfs: split out inode walk inode grabbing, Alex Elder <= [PATCH 14/18] xfs: implement batched inode lookups for AG walking, Dave Chinner Re: [PATCH 14/18] xfs: implement batched inode lookups for AG walking, Alex Elder [PATCH 17/18] xfs: convert buffer cache hash to rbtree, Dave Chinner [PATCH 06/18] xfs: rename xfs_buf_get_nodaddr to be more appropriate, Dave Chinner [PATCH 16/18] xfs: serialise inode reclaim within an AG, Dave Chinner [PATCH 15/18] xfs: batch inode reclaim lookup, Dave Chinner [PATCH 18/18] xfs: pack xfs_buf structure more tightly, Dave Chinner Re: [PATCH 0/18] xfs: metadata scalability V4, Alex Elder Re: [PATCH 0/18] xfs: metadata scalability V4, Christoph Hellwig

Previous by Date:	Re: XFS errors on large Infiniband fileserver setup, Christian Herzog
Next by Date:	Re: [PATCH 12/16] xfs: implement batched inode lookups for AG walking, Alex Elder
Previous by Thread:	[PATCH 13/18] xfs: split out inode walk inode grabbing, Dave Chinner
Next by Thread:	[PATCH 14/18] xfs: implement batched inode lookups for AG walking, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]