xfs
[Top] [All Lists]

[PATCH 14/16] xfs: serialise inode reclaim within an AG

To: xfs@xxxxxxxxxxx
Subject: [PATCH 14/16] xfs: serialise inode reclaim within an AG
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 22 Sep 2010 16:44:27 +1000
In-reply-to: <1285137869-10310-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1285137869-10310-1-git-send-email-david@xxxxxxxxxxxxx>
From: Dave Chinner <dchinner@xxxxxxxxxx>

Memory reclaim via shrinkers has a terrible habit of having N+M
concurrent shrinker executions (N = num CPUs, M = num kswapds) all
trying to shrink the same cache. When the cache they are all working
on is protected by a single spinlock, massive contention an
slowdowns occur.

Wrap the per-ag inode caches with a reclaim mutex to serialise
reclaim access to the AG. This will block concurrent reclaim in each
AG but still allow reclaim to scan multiple AGs concurrently. Allow
shrinkers to move on to the next AG if it can't get the lock, and if
we can't get any AG, then start blocking on locks.

To prevent reclaimers from continually scanning the same inodes in
each AG, add a cursor that tracks where the last reclaim got up to
and start from that point on the next reclaim. This should avoid
only ever scanning a small number of inodes at the satart of each AG
and not making progress. If we have a non-shrinker based reclaim
pass, ignore the cursor and reset it to zero once we are done.

Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
---
 fs/xfs/linux-2.6/xfs_sync.c |   24 ++++++++++++++++++++++++
 fs/xfs/xfs_ag.h             |    2 ++
 fs/xfs/xfs_mount.c          |    1 +
 3 files changed, 27 insertions(+), 0 deletions(-)

diff --git a/fs/xfs/linux-2.6/xfs_sync.c b/fs/xfs/linux-2.6/xfs_sync.c
index ea44b1d..7b06399 100644
--- a/fs/xfs/linux-2.6/xfs_sync.c
+++ b/fs/xfs/linux-2.6/xfs_sync.c
@@ -831,7 +831,9 @@ xfs_reclaim_inodes_ag(
        int                     error = 0;
        int                     last_error = 0;
        xfs_agnumber_t          ag;
+       int                     trylock = !!(flags & SYNC_TRYLOCK);
 
+restart:
        ag = 0;
        while ((pag = xfs_perag_get_tag(mp, ag, XFS_ICI_RECLAIM_TAG))) {
                unsigned long   first_index = 0;
@@ -840,6 +842,17 @@ xfs_reclaim_inodes_ag(
 
                ag = pag->pag_agno + 1;
 
+               if (!mutex_trylock(&pag->pag_ici_reclaim_lock)) {
+                       if (trylock) {
+                               trylock++;
+                               continue;
+                       }
+                       mutex_lock(&pag->pag_ici_reclaim_lock);
+               }
+
+               if (trylock)
+                       first_index = pag->pag_ici_reclaim_cursor;
+
                do {
                        struct xfs_inode *batch[XFS_LOOKUP_BATCH];
                        int     i;
@@ -892,8 +905,19 @@ xfs_reclaim_inodes_ag(
 
                } while (nr_found && !done && *nr_to_scan > 0);
 
+               pag->pag_ici_reclaim_cursor = (done || !trylock) ? 0 : 
first_index;
+               mutex_unlock(&pag->pag_ici_reclaim_lock);
                xfs_perag_put(pag);
        }
+
+       /*
+        * if we skipped any AG, and we still have scan count remaining, do
+        * another pass this time waiting on the reclaim locks.
+        */
+       if (trylock > 1 && *nr_to_scan) {
+               trylock = 0;
+               goto restart;
+       }
        return XFS_ERROR(last_error);
 }
 
diff --git a/fs/xfs/xfs_ag.h b/fs/xfs/xfs_ag.h
index 51c42c2..baeec83 100644
--- a/fs/xfs/xfs_ag.h
+++ b/fs/xfs/xfs_ag.h
@@ -230,6 +230,8 @@ typedef struct xfs_perag {
        rwlock_t        pag_ici_lock;   /* incore inode lock */
        struct radix_tree_root pag_ici_root;    /* incore inode cache root */
        int             pag_ici_reclaimable;    /* reclaimable inodes */
+       struct mutex    pag_ici_reclaim_lock;   /* serialisation point */
+       unsigned long   pag_ici_reclaim_cursor; /* reclaim restart point */
 
        /* for rcu-safe freeing */
        struct rcu_head rcu_head;
diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c
index d66e87c..59859c3 100644
--- a/fs/xfs/xfs_mount.c
+++ b/fs/xfs/xfs_mount.c
@@ -477,6 +477,7 @@ xfs_initialize_perag(
                pag->pag_agno = index;
                pag->pag_mount = mp;
                rwlock_init(&pag->pag_ici_lock);
+               mutex_init(&pag->pag_ici_reclaim_lock);
                INIT_RADIX_TREE(&pag->pag_ici_root, GFP_ATOMIC);
 
                if (radix_tree_preload(GFP_NOFS))
-- 
1.7.1

<Prev in Thread] Current Thread [Next in Thread>