xfs
[Top] [All Lists]

Re: [PATCH 06/18] xfs: convert pag_ici_lock to a spin lock

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 06/18] xfs: convert pag_ici_lock to a spin lock
From: Alex Elder <aelder@xxxxxxx>
Date: Tue, 14 Sep 2010 16:26:59 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1284461777-1496-7-git-send-email-david@xxxxxxxxxxxxx>
References: <1284461777-1496-1-git-send-email-david@xxxxxxxxxxxxx> <1284461777-1496-7-git-send-email-david@xxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Tue, 2010-09-14 at 20:56 +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> now that we are using RCU protection for the inode cache lookups,
> the lock is only needed on the modification side. Hence it is not
> necessary for the lock to be a rwlock as there are no read side
> holders anymore. Convert it to a spin lock to reflect it's exclusive
> nature.

This is of course contingent on the correctness of
the RCU change before this.  But this one looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>


> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
>  fs/xfs/linux-2.6/xfs_sync.c |   16 ++++++++--------

<Prev in Thread] Current Thread [Next in Thread>