| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/4] xfs: use unhashed buffers for size checks |
| From: | Alex Elder <aelder@xxxxxxx> |
| Date: | Fri, 10 Sep 2010 16:33:57 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1283958778-28610-3-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1283958778-28610-1-git-send-email-david@xxxxxxxxxxxxx> <1283958778-28610-3-git-send-email-david@xxxxxxxxxxxxx> |
| Reply-to: | aelder@xxxxxxx |
On Thu, 2010-09-09 at 01:12 +1000, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > When we are checking we can access the last block of each device, we > do not need to use hashed buffers as they will be tossed away > immediately. Use unhashed buffers for size checks so that all IO > prior to full in-memory structure initialisation does not use the > buffer cache hashes. This one also looks good, and again I agree with the comments Christoph made. I'll look for your update. Patch 3 in the series is good too; I'll look at the last patch (the switch to rbtrees) over the weekend. > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> |
| Previous by Date: | Re: [PATCH 1/4] xfs: kill XBF_FS_MANAGED buffers, Alex Elder |
|---|---|
| Next by Date: | [GIT PULL] XFS update #2 for 2.6.36-rc4, Alex Elder |
| Previous by Thread: | Re: [PATCH 2/4] xfs: use unhashed buffers for size checks, Dave Chinner |
| Next by Thread: | [PATCH 4/4] xfs: convert buffer cache hash to rbtree, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |