Re: [PATCH 4/5] xfs: use GFP_NOFS for page cache allocation

[Alex Elder <aelder@xxxxxxx>]

On Thu, 2010-07-15 at 10:38 +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Avoid a lockdep warning by preventing page cache allocation from
> recursing back into the filesystem during memory reclaim.

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>


> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
>  fs/xfs/linux-2.6/xfs_aops.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/xfs/linux-2.6/xfs_aops.c b/fs/xfs/linux-2.6/xfs_aops.c
> index ed9c3db..1075791 100644
> --- a/fs/xfs/linux-2.6/xfs_aops.c
> +++ b/fs/xfs/linux-2.6/xfs_aops.c
> @@ -1501,8 +1501,9 @@ xfs_vm_write_begin(
>       void                    **fsdata)
>  {
>       *pagep = NULL;
> -     return block_write_begin(file, mapping, pos, len, flags, pagep, fsdata,
> -                                                             xfs_get_blocks);
> +     return block_write_begin(file, mapping, pos, len,
> +                              (flags | AOP_FLAG_NOFS),

                            Why the parentheses?

> +                              pagep, fsdata, xfs_get_blocks);
>  }
>  
>  STATIC sector_t