| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 3/5] xfs: fix xfs_trans_add_item() lockdep warnings |
| From: | Alex Elder <aelder@xxxxxxx> |
| Date: | Thu, 15 Jul 2010 13:09:01 -0500 |
| Cc: | XFS Mailing List <xfs@xxxxxxxxxxx> |
| In-reply-to: | <1279154300-2018-4-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1279154300-2018-1-git-send-email-david@xxxxxxxxxxxxx> <1279154300-2018-4-git-send-email-david@xxxxxxxxxxxxx> |
| Reply-to: | aelder@xxxxxxx |
On Thu, 2010-07-15 at 10:38 +1000, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > xfs_trans_add_item() is called with ip->i_ilock held, which means it > is unsafe for memory reclaim to recurse back into the filesystem > (ilock is required in writeback). Hence the allocation needs to be > KM_NOFS to avoid recursion. Looks good. Reviewed-by: Alex Elder <aelder@xxxxxxx> > Lockdep report indicating memory allocation being called with the > ip->i_ilock held is as follows: . . . |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 2/5] xfs: simplify and remove xfs_ireclaim, Alex Elder |
|---|---|
| Next by Date: | Re: [PATCH 1/3] mm: add context argument to shrinker callback, Christoph Hellwig |
| Previous by Thread: | [PATCH 3/5] xfs: fix xfs_trans_add_item() lockdep warnings, Dave Chinner |
| Next by Thread: | Re: [PATCH 3/5] xfs: fix xfs_trans_add_item() lockdep warnings, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |