| To: | torvalds@xxxxxxxxxxxxxxxxxxxx |
|---|---|
| Subject: | [PATCH 5/6] xfs: remove nr_to_write writeback windup. |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Tue, 8 Jun 2010 10:38:06 +1000 |
| Cc: | linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <1275957487-23633-1-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1275957487-23633-1-git-send-email-david@xxxxxxxxxxxxx> |
From: Dave Chinner <dchinner@xxxxxxxxxx>
Now that the background flush code has been fixed, we shouldn't need to
silently multiply the wbc->nr_to_write to get good writeback. Remove
that code.
Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
---
fs/xfs/linux-2.6/xfs_aops.c | 8 --------
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/fs/xfs/linux-2.6/xfs_aops.c b/fs/xfs/linux-2.6/xfs_aops.c
index a0fa3bf..34640d6 100644
--- a/fs/xfs/linux-2.6/xfs_aops.c
+++ b/fs/xfs/linux-2.6/xfs_aops.c
@@ -1381,14 +1381,6 @@ xfs_vm_writepage(
if (!page_has_buffers(page))
create_empty_buffers(page, 1 << inode->i_blkbits, 0);
-
- /*
- * VM calculation for nr_to_write seems off. Bump it way
- * up, this gets simple streaming writes zippy again.
- * To be reviewed again after Jens' writeback changes.
- */
- wbc->nr_to_write *= 4;
-
/*
* Convert delayed allocate, unwritten or unmapped space
* to real space and flush out to disk.
--
1.7.1
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 4/6] writeback: pay attention to wbc->nr_to_write in write_cache_pages, Dave Chinner |
|---|---|
| Next by Date: | [PATCH 6/6] writeback: limit write_cache_pages integrity scanning to current EOF, Dave Chinner |
| Previous by Thread: | Re: [PATCH 4/6] writeback: pay attention to wbc->nr_to_write in write_cache_pages, Nick Piggin |
| Next by Thread: | [PATCH 6/6] writeback: limit write_cache_pages integrity scanning to current EOF, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |