| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 05/11] xfs: report iomap_bn in block base |
| From: | Alex Elder <aelder@xxxxxxx> |
| Date: | Thu, 29 Apr 2010 09:39:43 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20100428123015.330173874@xxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20100428122850.075189557@xxxxxxxxxxxxxxxxxxxxxx> <20100428123015.330173874@xxxxxxxxxxxxxxxxxxxxxx> |
| Reply-to: | aelder@xxxxxxx |
On Wed, 2010-04-28 at 08:28 -0400, Christoph Hellwig wrote: > plain text document attachment (xfs-iomap-cleanup-5) > Report the iomap_bn field of struct xfs_iomap in terms of filesystem blocks > instead of in terms of bytes. Shift the byte conversions into the caller, > and replace the IOMAP_DELAY and IOMAP_HOLE flag checks with checks for > HOLESTARTBLOCK and DELAYSTARTBLOCK. > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Looks good, although iomap_bn was previously a disk address, not a byte offset (as you suggest in your summary). I can fix it if you like. Reviewed-by: Alex Elder <aelder@xxxxxxx> > Index: xfs/fs/xfs/linux-2.6/xfs_aops.c > =================================================================== . . . |
| Previous by Date: | Re: [PATCH 04/11] xfs: report iomap_offset and iomap_bsize in block base, Alex Elder |
|---|---|
| Next by Date: | Re: [PATCH] xfstests: test extent size hints, Geoffrey Wehrman |
| Previous by Thread: | [PATCH 05/11] xfs: report iomap_bn in block base, Christoph Hellwig |
| Next by Thread: | [PATCH 09/11] xfs: clean up mapping size calculation in __xfs_get_blocks, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |