| To: | xfs@xxxxxxxxxxx |
|---|---|
| Subject: | [PATCH 1/7] xfsprogs: fix missing error check in xfs_rtfree_range in libxfs |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Tue, 19 Jan 2010 11:36:47 +1100 |
| In-reply-to: | <1263861413-13729-1-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1263861413-13729-1-git-send-email-david@xxxxxxxxxxxxx> |
When xfs_rtfind_forw() returns an error, the block is returned
uninitialised. xfs_rtfree_range() is not checking the error return,
so could be using an uninitialised block number for modifying bitmap
summary info.
Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx>
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
---
libxfs/xfs_rtalloc.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/libxfs/xfs_rtalloc.c b/libxfs/xfs_rtalloc.c
index 6c3da52..4fbdaa9 100644
--- a/libxfs/xfs_rtalloc.c
+++ b/libxfs/xfs_rtalloc.c
@@ -466,6 +466,8 @@ xfs_rtfree_range(
*/
error = xfs_rtfind_forw(mp, tp, end, mp->m_sb.sb_rextents - 1,
&postblock);
+ if (error)
+ return error;
/*
* If there are blocks not being freed at the front of the
* old extent, add summary data for them to be allocated.
--
1.6.5
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 6/7] xfsprogs: fix sign warning in mkfs directory code, Dave Chinner |
|---|---|
| Next by Date: | [PATCH 2/2] xfs: rearrange xfs_mod_sb() to avoid array subscript warning, Dave Chinner |
| Previous by Thread: | [PATCH 6/7] xfsprogs: fix sign warning in mkfs directory code, Dave Chinner |
| Next by Thread: | [PATCH 0/2] xfs: warning fixes needed for libxfs, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |