| To: | LKML <linux-kernel@xxxxxxxxxxxxxxx> |
|---|---|
| Subject: | [PATCH 13/17] xfs: Convert sync_page_range() to simple fdatawrite_range() |
| From: | Jan Kara <jack@xxxxxxx> |
| Date: | Fri, 21 Aug 2009 19:24:03 +0200 |
| Cc: | hch@xxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, Jan Kara <jack@xxxxxxx>, Felix Blyakher <felixb@xxxxxxx>, xfs@xxxxxxxxxxx |
| In-reply-to: | <1250875447-15622-1-git-send-email-jack@xxxxxxx> |
| References: | <1250875447-15622-1-git-send-email-jack@xxxxxxx> |
Christoph Hellwig says that it is enough for XFS to call
filemap_fdatawrite_range() instead of sync_page_range() because we do all the
waiting when forcing the log.
CC: Felix Blyakher <felixb@xxxxxxx>
CC: xfs@xxxxxxxxxxx
CC: Christoph Hellwig <hch@xxxxxx>
Signed-off-by: Jan Kara <jack@xxxxxxx>
---
fs/xfs/linux-2.6/xfs_lrw.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/xfs/linux-2.6/xfs_lrw.c b/fs/xfs/linux-2.6/xfs_lrw.c
index 7078974..a68053c 100644
--- a/fs/xfs/linux-2.6/xfs_lrw.c
+++ b/fs/xfs/linux-2.6/xfs_lrw.c
@@ -817,7 +817,7 @@ write_retry:
xfs_iunlock(xip, iolock);
if (need_i_mutex)
mutex_unlock(&inode->i_mutex);
- error2 = sync_page_range(inode, mapping, pos, ret);
+ error2 = filemap_fdatawrite_range(mapping, pos, pos + ret - 1);
if (!error)
error = error2;
if (need_i_mutex)
--
1.6.0.2
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 03/17] vfs: Remove syncing from generic_file_direct_write() and generic_file_buffered_write(), Jan Kara |
|---|---|
| Next by Date: | [PATCH 07/17] vfs: Introduce new helpers for syncing after writing to O_SYNC file or IS_SYNC inode, Jan Kara |
| Previous by Thread: | XFS Best Practices, Jeff Flowers |
| Next by Thread: | Re: [PATCH 13/17] xfs: Convert sync_page_range() to simple fdatawrite_range(), Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |