| To: | David Chinner <dgc@xxxxxxx> |
|---|---|
| Subject: | Re: Review: ensure EOF writes into existing extents update filesize |
| From: | Nathan Scott <nscott@xxxxxxxxxx> |
| Date: | Tue, 22 May 2007 14:10:14 +1000 |
| Cc: | Timothy Shimmin <tes@xxxxxxx>, xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx> |
| In-reply-to: | <20070522010326.GN85884050@sgi.com> |
| Organization: | Aconex |
| References: | <20070520233417.GA85884050@sgi.com> <738172E9F9634F7FC01B5B3C@timothy-shimmins-power-mac-g5.local> <20070522004414.GL85884050@sgi.com> <1179795779.6273.510.camel@edge> <20070522010326.GN85884050@sgi.com> |
| Reply-to: | nscott@xxxxxxxxxx |
| Sender: | xfs-bounce@xxxxxxxxxxx |
On Tue, 2007-05-22 at 11:03 +1000, David Chinner wrote: > On Tue, May 22, 2007 at 11:02:59AM +1000, Nathan Scott wrote: > > On Tue, 2007-05-22 at 10:44 +1000, David Chinner wrote: > > > On Mon, May 21, 2007 at 04:34:26PM +1000, Timothy Shimmin wrote: > > > I guess I need to ping Christoph and Nathan on this one.... > > > > Could you resend the patch to me please? I lost the previous copy > > while ruthlessly ploughing through my mail backlog. ;) > > Below. Looks pretty good to me - xfs_convert_page has been overlooked, I think - attached patch fixes that. You also initialise iomap_valid twice inside xfs_page_state_convert now ... I reverted that to just the once. cheers. -- Nathan
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Review: ensure EOF writes into existing extents update filesize, David Chinner |
|---|---|
| Next by Date: | Re: Review: ensure EOF writes into existing extents update filesize, David Chinner |
| Previous by Thread: | Re: Review: ensure EOF writes into existing extents update filesize, David Chinner |
| Next by Thread: | Re: Review: ensure EOF writes into existing extents update filesize, David Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |