xfs
[Top] [All Lists]

Re: [PATCH v3 08/11] xfsprogs: Add fls check into autoconf

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH v3 08/11] xfsprogs: Add fls check into autoconf
From: Jan Tulak <jtulak@xxxxxxxxxx>
Date: Tue, 4 Aug 2015 08:12:26 -0400 (EDT)
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20150804112103.GF18906@xxxxxxxxxxxxx>
References: <1438612789-17486-1-git-send-email-jtulak@xxxxxxxxxx> <1438612789-17486-9-git-send-email-jtulak@xxxxxxxxxx> <20150804112103.GF18906@xxxxxxxxxxxxx>
Thread-index: rKhlVe58roOeHqFtk4fDOsPRBZOZ7w==
Thread-topic: xfsprogs: Add fls check into autoconf

----- Original Message -----
> From: "Christoph Hellwig" <hch@xxxxxxxxxxxxx>
> To: "Jan Tulak" <jtulak@xxxxxxxxxx>
> Cc: hch@xxxxxxxxxxxxx, xfs@xxxxxxxxxxx
> Sent: Tuesday, August 4, 2015 1:21:03 PM
> Subject: Re: [PATCH v3 08/11] xfsprogs: Add fls check into autoconf
> 
> Can't you just use something like:
> 
> AC_CHECK_DECL([fls],
>         [AC_DEFINE([HAVE_FLS_PROTOTYPE], [1],
>        [Define to 1 if have fls prototype])],
>        [],
>        [#include <string.h>])
> 

You mean to replace the entire autoconf part of the patch with this? 
I will try it. Autoconf is still a bit of a black magic for me, so I
used the already existing checks. :-)

Cheers,
Jan

-- 
Jan Tulak
jtulak@xxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>